notary/internal/tlog: change TileReader.Reject to TileReader.SaveTiles

TileReader has a ReadTiles method that returns unverified tiles,
and then the implementation needs some way to distinguish tiles
that validate from ones that don't. The old approach was to let
ReadTiles assume the tiles would validate and have the validator
promise to call Reject for any tiles that did not validate.
This created uncertainty about the state of the tiles immediately
after a ReadTiles call returned - was a Reject on its way or not?

A better approach, taken in this CL, is to have ReadTiles assume
that tiles it returns are unvalidated until the client calls SaveTiles
with the ones that do pass validation.

Addresses a TODO from the initial review of TileReader.

Change-Id: I69c8cf8aecf33b7fa904646258ae5ffbb915a09e
Run-TryBot: Russ Cox <>
TryBot-Result: Gobot Gobot <>
Reviewed-by: Filippo Valsorda <>
3 files changed
tree: 91942497a24288a23cbba83ac8d738080a28ebc5
  1. .gitattributes
  2. .gitignore
  9. apidiff/
  10. cmd/
  11. codereview.cfg
  12. ebnf/
  13. ebnflint/
  14. errors/
  15. fsnotify/
  16. go.mod
  17. go.sum
  18. inotify/
  19. io/
  20. mmap/
  21. notary/
  22. old/
  23. rand/
  24. shiny/
  25. shootout/
  26. utf8string/
  27. winfsnotify/


This subrepository holds experimental and deprecated (in the old directory) packages.

The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.

Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.

In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)

Caveat emptor.