slog: rewrite commonHandler

Reorganize and simplify commonHandler.Handle.

- Simplify the appender interface by removing all state from it.

- Introduce a handleState struct to track state. In particular, we have
  to track whether or not we have written the first key, to know when to
  write a separator. This fixes a bug in the previous version.

Also, improve commonHandler tests to check preformatted Attrs.

Change-Id: Ia87eee200cea1617ff5bae486e8a52eab7aadc5d
Reviewed-by: Alan Donovan <>
TryBot-Result: Gopher Robot <>
Run-TryBot: Jonathan Amsterdam <>
6 files changed
tree: 54b50ad8751729d092b3dbf6d752c1ac596fc88e
  1. apidiff/
  2. cmd/
  3. constraints/
  4. devtools/
  5. ebnf/
  6. ebnflint/
  7. errors/
  8. event/
  9. inotify/
  10. io/
  11. jsonrpc2/
  12. maps/
  13. mmap/
  14. rand/
  15. shiny/
  16. shootout/
  17. slices/
  18. slog/
  19. sumdb/
  20. typeparams/
  21. utf8string/
  22. .gitattributes
  23. .gitignore
  24. codereview.cfg
  26. go.mod
  27. go.sum



This subrepository holds experimental and deprecated (in the old directory) packages.

The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.

Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.

In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)

Caveat emptor.