tree c6efc970a5210d63f65ccc1b769a174f3509ba83
parent cafedaf64729e54f9b9aac879ac5ee30112d02a2
author Jonathan Amsterdam <jba@google.com> 1674802385 -0500
committer Jonathan Amsterdam <jba@google.com> 1674848254 +0000

slog: correctly represent the zero Time in a Value

Storing the zero time.Time in a Value and then retrieving it
gave a non-zero time. The reason is that UnixNanos is called
to store a time.Time in a Value, and its result is undefined
for the zero time (or any time before the year 1678 or after 2262,
but I don't think we need to worry about those).

One solution, implemented in this CL, is to use a nil *time.Location
to represent the zero time. the time.Time.Location method never
returns nil, so a Value with a nil *time.Location in its `any` field
cannot be mistaken for any other Value, time.Time or otherwise.

Change-Id: Icba66f2ec16e21ed574c3336e1996ed759ab1c17
Reviewed-on: https://go-review.googlesource.com/c/exp/+/463817
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>