tree bd783f516081f8af7179a49a3cd584938e8c12ad
parent b3083d562e1d0d589e2a57d29d38d38d555f9cbc
author Jean de Klerk <deklerk@google.com> 1620402936 -0600
committer Jean de Klerk <deklerk@google.com> 1620669587 +0000

cmd/gorelease: fix test runner, and implementation of existing versions check

Currently, all tests pass because the test runner uses the for-loop-scoped
"test" in multiple parallel tests. This change locally scopes it to the for
block so that each parallel test run has its own "test".

That causes some tests to fail. The primary failure is that existing version
check is happening in loadLocalModule. loadLocalModule uses the release version
(the -version flag), whereas loadDownloadedModule uses the base version. Since
loadLocalModule uses the release version, prepareLoadDir (performed inside both
load* functions) will use the release version for the replace directive, which
means "go list" will report the release version. The existing version check uses
"go list", so it's guaranteed to always fail: the release specified will always
be reported as an existing release!

The change is to move the existing version check to loadDownloadedModule, which
performs "go list" as before but now it's only checking things which already
exist, not which the user is proposing should exist.

Fixes golang/go#45892

Change-Id: I5a9776d6ae1af6718b3c39946945c4bbb108a2fc
Reviewed-on: https://go-review.googlesource.com/c/exp/+/318029
Trust: Jean de Klerk <deklerk@google.com>
Run-TryBot: Jean de Klerk <deklerk@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>