| commit | 202106c2c44dd768b066fadb4329158893fdee35 | [log] [tgz] |
|---|---|---|
| author | Jean de Klerk <deklerk@google.com> | Fri May 07 09:55:36 2021 -0600 |
| committer | Jean de Klerk <deklerk@google.com> | Mon May 10 17:59:47 2021 +0000 |
| tree | bd783f516081f8af7179a49a3cd584938e8c12ad | |
| parent | b3083d562e1d0d589e2a57d29d38d38d555f9cbc [diff] |
cmd/gorelease: fix test runner, and implementation of existing versions check Currently, all tests pass because the test runner uses the for-loop-scoped "test" in multiple parallel tests. This change locally scopes it to the for block so that each parallel test run has its own "test". That causes some tests to fail. The primary failure is that existing version check is happening in loadLocalModule. loadLocalModule uses the release version (the -version flag), whereas loadDownloadedModule uses the base version. Since loadLocalModule uses the release version, prepareLoadDir (performed inside both load* functions) will use the release version for the replace directive, which means "go list" will report the release version. The existing version check uses "go list", so it's guaranteed to always fail: the release specified will always be reported as an existing release! The change is to move the existing version check to loadDownloadedModule, which performs "go list" as before but now it's only checking things which already exist, not which the user is proposing should exist. Fixes golang/go#45892 Change-Id: I5a9776d6ae1af6718b3c39946945c4bbb108a2fc Reviewed-on: https://go-review.googlesource.com/c/exp/+/318029 Trust: Jean de Klerk <deklerk@google.com> Run-TryBot: Jean de Klerk <deklerk@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.