| commit | 1b447090c38c11499ba04220f069c4421b188685 | [log] [tgz] |
|---|---|---|
| author | Jonathan Amsterdam <jba@google.com> | Sat Dec 17 22:54:46 2022 -0500 |
| committer | Jonathan Amsterdam <jba@google.com> | Tue Dec 27 20:39:29 2022 +0000 |
| tree | 3045ade2a398aba709c932e9416041dd202e235d | |
| parent | b2135658b1b77bc94efaee4543ec9ad0b88f3d5f [diff] |
slog: move runtime.Callers up the stack runtime.Callers takes time proportional to its skip argument. So we can make our code faster by calling it with a smaller skip. Move the call to runtime.Callers closer to the exported functions of this package. Moving it all the way to the top would mean a lot of duplicate code, so we compromise and move it partway up, to a point where we only have to write the call three times. This change improves our benchmark times from 4 to 20 percent. Thanks to Austin Clements for cluing me in to this property of runtime.Callers. Change-Id: If9dcaa3d6a7f7bc4f60aa2ad86a56ca5b652e62f Reviewed-on: https://go-review.googlesource.com/c/exp/+/458210 Reviewed-by: Alan Donovan <adonovan@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.