Google Git
Sign in
go / dl / af982ab5594b6fc8e23ca54e1fb53b6499eef6ef
commitaf982ab5594b6fc8e23ca54e1fb53b6499eef6ef[log] [tgz]
authorAgniva De Sarker <agnivade@yahoo.co.in>Mon Feb 04 11:05:06 2019 +0530
committerFilippo Valsorda <filippo@golang.org>Mon Feb 04 18:27:17 2019 +0000
tree55c2b08126841565dc6a1be2412b979de98d8a74
parenteb5f36764f93a47620398326233d5428d1706a59 [diff]
internal/genv: fix release notes link for minor versions

Also corrected the code in case of unrecognized version.

According to the docs, nil is returned when the regex does not match.
And in case of a partial or full match, the length of the slice
is always equal to the no. of subexpressions.
For the subexpressions that did not match, the string will be empty.

So the length check was logically wrong. It's just that since the length
of a nil slice is 0, it accidentally turned out to be correct.

Fixes golang/go#26976

Change-Id: Ic9e43d13877d747df20c15949436e355d2fd448d
Reviewed-on: https://go-review.googlesource.com/c/160920
Reviewed-by: Filippo Valsorda <filippo@golang.org>
29 files changed
tree: 55c2b08126841565dc6a1be2412b979de98d8a74
  1. go1.10/
  2. go1.10.1/
  3. go1.10.2/
  4. go1.10.3/
  5. go1.10.4/
  6. go1.10.5/
  7. go1.10.6/
  8. go1.10.7/
  9. go1.10.8/
  10. go1.10beta1/
  11. go1.10beta2/
  12. go1.10rc1/
  13. go1.10rc2/
  14. go1.11/
  15. go1.11.1/
  16. go1.11.2/
  17. go1.11.3/
  18. go1.11.4/
  19. go1.11.5/
  20. go1.11beta1/
  21. go1.11beta2/
  22. go1.11beta3/
  23. go1.11rc1/
  24. go1.11rc2/
  25. go1.12beta1/
  26. go1.12beta2/
  27. go1.8/
  28. go1.8.1/
  29. go1.8.2/
  30. go1.8.3/
  31. go1.8.4/
  32. go1.8.5/
  33. go1.8.6/
  34. go1.8.7/
  35. go1.8beta1/
  36. go1.8beta2/
  37. go1.8rc1/
  38. go1.8rc2/
  39. go1.8rc3/
  40. go1.9/
  41. go1.9.1/
  42. go1.9.2/
  43. go1.9.3/
  44. go1.9.4/
  45. go1.9.5/
  46. go1.9.6/
  47. go1.9.7/
  48. go1.9beta1/
  49. go1.9beta2/
  50. go1.9rc1/
  51. go1.9rc2/
  52. gotip/
  53. internal/
  54. codereview.cfg
  55. README.md
README.md

golang.org/dl

This repository holds the Go wrapper programs that run specific versions of Go, such as go get golang.org/dl/go1.10.3 and go get golang.org/dl/gotip.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “dl:” in the subject line, so it is easy to find.