)]}' { "log": [ { "commit": "ac862fd6552b739f50ba812382eed75745a129b1", "tree": "15d98151971108b94c6c4f9ea84b3f5f0d3c4595", "parents": [ "4da508dbc9480dcedb20e32d9fcbc67ade44e413" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Sep 08 05:03:48 2026 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Sep 08 09:27:31 2026 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I9db7e786f9426e6884f5b8d34af830194f3f08d1\nReviewed-on: https://go-review.googlesource.com/c/debug/+/829005\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "4da508dbc9480dcedb20e32d9fcbc67ade44e413", "tree": "b5298bc48afc1e2bab33d75bdf94d8a272f9a462", "parents": [ "cf82a13506dfaac5f72520d3ca58e9cee591b0ca" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 19 16:59:36 2026 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 19 10:14:27 2026 -0700" }, "message": "all: upgrade go directive to at least 1.26.0 [generated]\n\nBy now Go 1.27.0 has been released, and Go 1.25 is no longer supported\nper the Go Release Policy (see https://go.dev/doc/devel/release#policy).\n\nSee https://go.dev/doc/godebug#go-126 for GODEBUG setting changes\nrelevant to Go 1.26.\n\nFor golang/go#69095.\n\n[git-generate]\n(cd . \u0026\u0026 go get go@1.26.0 \u0026\u0026 go mod tidy)\n\nChange-Id: I702f076b3be9e7bb1469b8ef5e2ce80ea3bdfda5\nReviewed-on: https://go-review.googlesource.com/c/debug/+/817920\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "cf82a13506dfaac5f72520d3ca58e9cee591b0ca", "tree": "f2968397bce1ba628d3fb106cc58c3977c073aa9", "parents": [ "df4e898c2b6ac5f3ec9c5846b3a3595b3d186ad8" ], "author": { "name": "racequite", "email": "quiterace@gmail.com", "time": "Fri Aug 07 01:34:25 2026 +0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Aug 14 19:48:06 2026 -0700" }, "message": "cmd/viewcore: fix commandPath recursion\n\ncommandPath recursively called itself with the same command when the\ncommand had a parent. The recursion therefore never reached the root\ncommand and eventually caused a stack overflow.\n\nRecurse with c.Parent() so each call advances toward the root. Add\ntable-driven tests covering root, one-level, and two-level command paths.\n\nChange-Id: I8d258a9f2d4d2c42c1cd66df0873fa99185a8aa9\nReviewed-on: https://go-review.googlesource.com/c/debug/+/811640\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Keith Randall \u003ckhr@golang.org\u003e\n" }, { "commit": "df4e898c2b6ac5f3ec9c5846b3a3595b3d186ad8", "tree": "81c569ec7b621f8bf4153a7c8874f3eba3830bd7", "parents": [ "31c034ca73bf59e90557b551e024d20505cbad45" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Jul 08 05:08:09 2026 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Jul 08 08:41:17 2026 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I4e75d5d03390637e330b5dbd75a3ec9b7f4e5e3c\nReviewed-on: https://go-review.googlesource.com/c/debug/+/798142\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "31c034ca73bf59e90557b551e024d20505cbad45", "tree": "74e185b789b33101a9e6c79b1ed7b668a18f9e32", "parents": [ "fe1226a9c1ff101bc0d8dfb374110bca73e444d3" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Jun 08 05:02:28 2026 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Jun 08 08:09:59 2026 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I31f769ef74c09f5bcee29249bf55844cf0a863d0\nReviewed-on: https://go-review.googlesource.com/c/debug/+/788063\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "fe1226a9c1ff101bc0d8dfb374110bca73e444d3", "tree": "def43fbf04abfebb11cc449e43ae202aa97fe375", "parents": [ "8c4c11b9c27cbb3970affcf8d74f88deaf92b05c" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri May 08 05:02:25 2026 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri May 08 07:56:35 2026 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I73cba98e825f7f0a7e886897ac4080e231e2f97a\nReviewed-on: https://go-review.googlesource.com/c/debug/+/775682\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "8c4c11b9c27cbb3970affcf8d74f88deaf92b05c", "tree": "b70721f983c09f2a49aba954d37082d1f1b6fa47", "parents": [ "80696ebb970510bfa32d19b63ae05e1a33b019d1" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Apr 08 05:02:18 2026 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Apr 09 04:45:33 2026 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I46eb8357a54789aacaa3825e138e083cc2db9fec\nReviewed-on: https://go-review.googlesource.com/c/debug/+/763525\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "80696ebb970510bfa32d19b63ae05e1a33b019d1", "tree": "a833c12d92835c8f5d7b83fc69399f3727d8544c", "parents": [ "563fac5f3b416fcb1e6f8d4976d814fa5dda6ef2" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sun Mar 08 04:02:42 2026 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Mar 09 18:41:26 2026 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I33d5a53e8dfb44817d50987e06789618f77f071f\nReviewed-on: https://go-review.googlesource.com/c/debug/+/752841\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "563fac5f3b416fcb1e6f8d4976d814fa5dda6ef2", "tree": "fd0ef0e649bc87097b2727de14bf51df0fe89c65", "parents": [ "6874fb8ce24e2768d6adecd339f37cd4dd037f84" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Mon Mar 02 05:58:29 2026 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Mar 09 09:19:41 2026 -0700" }, "message": "internal/gocore: move core of runReachable to Process.Reachable\n\n...and turn it into an iteration so that we can later offer the option\nto printe more (all) paths.\n\nHaving Process.Reachable also makes it easier to write a test for some\nupcoming functionality (defer/panic as roots). In all, it seems like a\nnicer separation of concerns.\n\nI tested the main functionality by comparing the output pre- and\npost-this CL. It looks identical:\n\n $ ~/gob/go/debug-readonly/viewcore ~/tmp/viewcore/core.server_test.3024 --exe ~/tmp/viewcore/server_test --base ~/src/server reachable 203cbbf287e8 2\u003e/dev/null\n rpc.NewStreamImpl.func1\n rpc.(*eventQueue).pop.q →\n 203cbc0dba40 rpc.eventQueue .list.ptr →\n 203cbbf287e8 *rpc.clientEvent\n\nThe output of the test is the more similar to the way I\u0027d like to show\nthis output in the end:\n\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513aa8 main.main.func1.gowrap7\n gocore_test.go:481: 0x55a36e512ed4 main.complicatedRetain\n gocore_test.go:512: unk [SP+0x108] 0xc000047fa0 (unsafe.Pointer) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513aa8 main.main.func1.gowrap7\n gocore_test.go:481: 0x55a36e512ed4 main.complicatedRetain\n gocore_test.go:512: unk [SP+0xe8] 0xc000047f80 (unsafe.Pointer) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513aa8 main.main.func1.gowrap7\n gocore_test.go:481: 0x55a36e512ed4 main.complicatedRetain\n gocore_test.go:512: unk [SP+0xc8] 0xc000047f60 (unsafe.Pointer) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513aa8 main.main.func1.gowrap7\n gocore_test.go:481: 0x55a36e512ed4 main.complicatedRetain\n gocore_test.go:512: unk [SP+0x50] 0xc000047ee8 (unsafe.Pointer) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513aa8 main.main.func1.gowrap7\n gocore_test.go:481: 0x55a36e512ed4 main.complicatedRetain\n gocore_test.go:512: ref [SP+0x120] 0xc000047fb8 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513b08 main.main.func1.gowrap6\n gocore_test.go:481: 0x55a36e5135c8 main.hardAliasRetain\n gocore_test.go:512: otherRef [SP+0x20] 0xc000047790 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513b08 main.main.func1.gowrap6\n gocore_test.go:481: 0x55a36e5135c8 main.hardAliasRetain\n gocore_test.go:512: ref [SP+0x48] 0xc0000477b8 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513b68 main.main.func1.gowrap5\n gocore_test.go:481: 0x55a36e5134d7 main.aliasRetain\n gocore_test.go:512: otherRef [SP+0x30] 0xc000046fb8 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513b68 main.main.func1.gowrap5\n gocore_test.go:481: 0x55a36e5134d7 main.aliasRetain\n gocore_test.go:512: ref [SP+0x30] 0xc000046fb8 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513bc8 main.main.func1.gowrap4\n gocore_test.go:481: 0x55a36e513347 main.hardRenameRetain\n gocore_test.go:512: otherRef [SP+0x18] 0xc000046798 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513c28 main.main.func1.gowrap3\n gocore_test.go:481: 0x55a36e513273 main.renameRetain\n gocore_test.go:512: otherRef [SP+0x30] 0xc000045fb8 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513c28 main.main.func1.gowrap3\n gocore_test.go:481: 0x55a36e513273 main.renameRetain\n gocore_test.go:512: ref [SP+0x30] 0xc000045fb8 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513c88 main.main.func1.gowrap2\n gocore_test.go:481: 0x55a36e5133f3 main.multiFrame1Retain\n gocore_test.go:481: 0x55a36e513433 main.multiFrame2Retain\n gocore_test.go:481: 0x55a36e513473 main.multiFrame3Retain\n gocore_test.go:481: 0x55a36e5131b3 main.retain\n gocore_test.go:512: ref [SP+0x30] 0xc000045740 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:475: [goroutine]\n gocore_test.go:481: 0x55a36e513ce8 main.main.func1.gowrap1\n gocore_test.go:481: 0x55a36e5131b3 main.retain\n gocore_test.go:512: ref [SP+0x30] 0xc000044fb8 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n gocore_test.go:473: [global]\n gocore_test.go:512: main.gPlainMyObj 0x55a36e65d080 (*main.myObj) → 0xc00009a0a0 (main.myObj)\n\nChange-Id: I953e39fc0c3357c7c636144e80c42a6fd2d737b2\nReviewed-on: https://go-review.googlesource.com/c/debug/+/750481\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "6874fb8ce24e2768d6adecd339f37cd4dd037f84", "tree": "7f028c3e15dc8107184a274446c160f037876407", "parents": [ "294b3ab97995631094e66beb324ab9e9d86c924b" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Tue Feb 24 08:14:54 2026 -0800" }, "committer": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Tue Mar 03 07:36:38 2026 -0800" }, "message": "internal/gocore: have single entry point for makeMemRoot (refactor)\n\nI was reading through the code and found that getting all references\n(places where roots are made) was made a little more difficult by having\na separate `p.makeMemRoot` versus `makeMemRoot`.\n\nI can understand why it was done: to make `gocore.Core(...)` function\nrely more on `core.Process` and make it clearer what the dependencies\nare. But the `nRoots` passing is awkward.\n\nChange-Id: I3d8f6f8d9c46a09740a4d28fbe742e0af27b806a\nReviewed-on: https://go-review.googlesource.com/c/debug/+/748440\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\n" }, { "commit": "294b3ab97995631094e66beb324ab9e9d86c924b", "tree": "ebcd77d94951aefd0fe95b562e2fcb9c1404e36b", "parents": [ "65db3dee0652b101157b3d339a1f1e144b7b854a" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Feb 11 18:54:02 2026 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Feb 11 11:14:05 2026 -0800" }, "message": "all: upgrade go directive to at least 1.25.0 [generated]\n\nBy now Go 1.26.0 has been released, and Go 1.24 is no longer supported\nper the Go Release Policy (see https://go.dev/doc/devel/release#policy).\n\nSee go.dev/doc/godebug#go-125 for GODEBUG changes relevant to Go 1.25.\n\nFor golang/go#69095.\n\n[git-generate]\n(cd . \u0026\u0026 go get go@1.25.0 \u0026\u0026 go mod tidy)\n\nChange-Id: I793ab410f2a42356424e78580a8329616f8e3b38\nReviewed-on: https://go-review.googlesource.com/c/debug/+/744500\nReviewed-by: Junyang Shao \u003cshaojunyang@google.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "65db3dee0652b101157b3d339a1f1e144b7b854a", "tree": "1db411c7d7be201ef05cd34d467127415968673c", "parents": [ "00978851aeb5f9316906f0dddf32e032395b8915" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sun Feb 08 08:51:33 2026 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Feb 09 08:13:00 2026 -0800" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I9a71726a4ab9692296f952e31e881f4efdd4fca8\nReviewed-on: https://go-review.googlesource.com/c/debug/+/743141\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "00978851aeb5f9316906f0dddf32e032395b8915", "tree": "bdfacf04819f6d4f08a3c69fc2555f4c0d98a97d", "parents": [ "77509fafd08189faf5590ae64d152731ac9cb3e3" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jan 08 04:02:35 2026 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Jan 09 08:09:24 2026 -0800" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I74bd7148c8327f1c662e99183a5037a1119e87ee\nReviewed-on: https://go-review.googlesource.com/c/debug/+/734801\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Junyang Shao \u003cshaojunyang@google.com\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "77509fafd08189faf5590ae64d152731ac9cb3e3", "tree": "ba5652e2c0fe21dc490b6df3b5171b6ef950534d", "parents": [ "b857bac600d6e86a05884b7efb5c3a165c8d77a6" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Dec 08 04:06:14 2025 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Dec 08 08:57:39 2025 -0800" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I3d6d044e421dcfe16400eb7b0ae61f83ba728c83\nReviewed-on: https://go-review.googlesource.com/c/debug/+/728002\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "b857bac600d6e86a05884b7efb5c3a165c8d77a6", "tree": "48e3ea54ba93229ca48e50afee73df99ad3b3a93", "parents": [ "55b825dbc0bb9a0653b1ffd8abe2046f7fa4775b" ], "author": { "name": "Derek Parker", "email": "parkerderek86@gmail.com", "time": "Thu Oct 23 10:23:06 2025 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Nov 12 10:01:11 2025 -0800" }, "message": "dwtest: add more loclist tests\n\nAdds tests to verify changes in CL 696575:\n\nhttps://go-review.googlesource.com/c/go/+/696575\n\nUpdates the dwdumploc program to search for locations with liveness in\nmind. For example, for return parameters (especially unnamed) they will\nnot be live until the function return (e.g. OpMakeResult) and so trying\nto find the location list with a PC value at the function entry will not\nyield anything.\n\nChange-Id: Ia7c1455e7c875bdf29fca5e2fb540cd771555635\nReviewed-on: https://go-review.googlesource.com/c/debug/+/714340\nAuto-Submit: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nReviewed-by: Junyang Shao \u003cshaojunyang@google.com\u003e\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "55b825dbc0bb9a0653b1ffd8abe2046f7fa4775b", "tree": "d46083510f055b090945862d4ffafa324a024471", "parents": [ "90f81a05abb82d96fe6211f3109fa83bc5cdb5bb" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat Nov 08 04:02:19 2025 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Nov 11 07:06:19 2025 -0800" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I5b3e5379beaec971e0a1925a56deb53a0f120670\nReviewed-on: https://go-review.googlesource.com/c/debug/+/718962\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "90f81a05abb82d96fe6211f3109fa83bc5cdb5bb", "tree": "8e04ce25aec073ea2a868f27d2f30509e93de4a5", "parents": [ "6760accd74399066ccf0420b5fe9423139a25052" ], "author": { "name": "Sean Liao", "email": "sean@liao.dev", "time": "Sun Oct 26 13:47:09 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 29 11:28:04 2025 -0700" }, "message": "all: eliminate vet diagnostics\n\nFor golang/go#74011\n\nChange-Id: Ia2934d5a78be6a5ce38bb5b39b458b34077575b8\nReviewed-on: https://go-review.googlesource.com/c/debug/+/714222\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nAuto-Submit: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "6760accd74399066ccf0420b5fe9423139a25052", "tree": "29d373b2d9f8af0000874e3e191102d99c984456", "parents": [ "50276fecbe943f86311074ee213334126875bfde" ], "author": { "name": "cuishuang", "email": "imcusg@gmail.com", "time": "Mon Oct 20 17:11:24 2025 +0800" }, "committer": { "name": "t hepudds", "email": "thepudds1460@gmail.com", "time": "Tue Oct 21 09:04:41 2025 -0700" }, "message": "README.md: fix comment\n\nChange-Id: Iecffe3a9bdcd76b5fcc2f984312becb307de08d4\nReviewed-on: https://go-review.googlesource.com/c/debug/+/713080\nReviewed-by: t hepudds \u003cthepudds1460@gmail.com\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "50276fecbe943f86311074ee213334126875bfde", "tree": "3bc65848df49d8c55e49b88b6facf9fcde15339c", "parents": [ "ffa2f5b3db79a759cad56fbacfb77b28c1bd1247" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 08 05:02:20 2025 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 08 08:23:58 2025 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I75994ec70280798a48a0d60de16d20c69294e7c5\nReviewed-on: https://go-review.googlesource.com/c/debug/+/710077\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "ffa2f5b3db79a759cad56fbacfb77b28c1bd1247", "tree": "842c0775de734a6fb95554d7a1f7f2a2c86c79e0", "parents": [ "3dd331509f104ffaca6cef3af764595e32a3b554" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Fri Aug 29 18:32:12 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Sep 09 07:59:16 2025 -0700" }, "message": "cmd/viewcore: print correct argument when parsing fails\n\nThis can result in an out-of-bounds failure instead of a parsing error\nas one expects.\n\nChange-Id: Iad88f5688d3967bcbe92bf4c91923a3b975e9e07\nReviewed-on: https://go-review.googlesource.com/c/debug/+/699976\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nReviewed-by: Annie Poláková \u003cannieplkv@gmail.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "3dd331509f104ffaca6cef3af764595e32a3b554", "tree": "d9bd0266da04820b1554da1be62b9e230dcc02a5", "parents": [ "489b700451bf0fdc75b1cb3a7bfa3c1dbe9ee3a6" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Fri Aug 29 18:31:42 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Sep 09 07:43:52 2025 -0700" }, "message": "internal/gocore: fix pointer locations for small objects in green tea\n\nThe tests are currently broken when GOEXPERIMENT\u003dgreenteagc because that\nshifted where the pointer/scalar bits are located for small objects a\nlittle bit. This change modifies gocore to look in the right place and\ndetect if GOEXPERIMENT\u003dgreenteagc is enabled (and if we\u0027re using Green\nTea in general, if/when it becomes the default).\n\nThis was not caught by the builders because we don\u0027t have an x/debug\nbuilder that sets the GOEXPERIMENT.\n\nChange-Id: I746ce601ebc12738920616889200f23642f7280f\nReviewed-on: https://go-review.googlesource.com/c/debug/+/699975\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nCommit-Queue: Nicolas Hillegeer \u003caktau@google.com\u003e\n" }, { "commit": "489b700451bf0fdc75b1cb3a7bfa3c1dbe9ee3a6", "tree": "610ba277558c437a2df43f616aeb2c57c4c265cd", "parents": [ "b0e58da7edbe5ba3d512010bae73b3fa63b7f95e" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sun Sep 07 05:02:04 2025 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sun Sep 07 20:32:34 2025 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Ibb386c1e4fe1ab20b10057b044f0b1e472d58849\nReviewed-on: https://go-review.googlesource.com/c/debug/+/701038\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "b0e58da7edbe5ba3d512010bae73b3fa63b7f95e", "tree": "9d55b4443e253c1cf9d3b2b6c0a1a3e0c037830d", "parents": [ "7e03a99967c330902a86c46b243d084ef6f11ba3" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 13 14:21:33 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 13 07:42:49 2025 -0700" }, "message": "all: upgrade go directive to at least 1.24.0 [generated]\n\nBy now Go 1.25.0 has been released, and Go 1.23 is no longer supported\nper the Go Release Policy (see https://go.dev/doc/devel/release#policy).\n\nFor golang/go#69095.\n\n[git-generate]\n(cd . \u0026\u0026 go get go@1.24.0 \u0026\u0026 go mod tidy \u0026\u0026 go fix ./... \u0026\u0026 go mod edit -toolchain\u003dnone)\n\nChange-Id: I591f022030f4a57d9f92eb44a1893ffe4db0b9c7\nReviewed-on: https://go-review.googlesource.com/c/debug/+/695536\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "7e03a99967c330902a86c46b243d084ef6f11ba3", "tree": "4d04e949ba85d7737c5817c274b3b43e383390b5", "parents": [ "cd5b42b00cd15a492659c81a153662690d2b8e83" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Aug 07 05:04:16 2025 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Aug 07 07:53:13 2025 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I75b9c4366fba6eb62c3cfecfd07b7b7d5e7e7e96\nReviewed-on: https://go-review.googlesource.com/c/debug/+/693996\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "cd5b42b00cd15a492659c81a153662690d2b8e83", "tree": "e07414cf270e8eedf860c1884287a529177d83da", "parents": [ "7f2f3414b380b4d8fabfcf75a096c133ebe1c5c0" ], "author": { "name": "Keith Randall", "email": "khr@golang.org", "time": "Fri Jul 25 22:42:40 2025 -0700" }, "committer": { "name": "Keith Randall", "email": "khr@golang.org", "time": "Tue Jul 29 12:42:20 2025 -0700" }, "message": "internal/gocore: reverse sense of indirect test\n\nCL 682075 is 100% wrong. IsIndir is true if the direct bit is *not* set.\n\nChange-Id: Ife8cc7b08e7051310e3f799bf6e58822f07d1733\nReviewed-on: https://go-review.googlesource.com/c/debug/+/690156\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "7f2f3414b380b4d8fabfcf75a096c133ebe1c5c0", "tree": "9bc3e7acb848532df81dc55e72f12d7b93ffb1ce", "parents": [ "63dd16992830f0c334053053f7a8015ded6463a1" ], "author": { "name": "khr@golang.org", "email": "khr@golang.org", "time": "Mon Jul 21 17:15:08 2025 -0700" }, "committer": { "name": "Keith Randall", "email": "khr@google.com", "time": "Mon Jul 21 17:29:11 2025 -0700" }, "message": "internal/gocore: fix IsPtr method\n\nIt should look up by word index, not byte index, and it\nneeds a \u00261 mask also.\n\nChange-Id: Id4b25b120b8b043184e53d70450a5f0b6b197c37\nReviewed-on: https://go-review.googlesource.com/c/debug/+/689375\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\n" }, { "commit": "63dd16992830f0c334053053f7a8015ded6463a1", "tree": "796e0062c735a41b5e0c8a29062d20d40559033a", "parents": [ "5fb72a4cec98078dcb0ea90ce9c97b5a1742dffd" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Jul 09 12:07:13 2025 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Jul 09 13:13:26 2025 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Idea612aa7f786b74ee284d20ef173fe4f503565e\nReviewed-on: https://go-review.googlesource.com/c/debug/+/687036\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "5fb72a4cec98078dcb0ea90ce9c97b5a1742dffd", "tree": "70a4468c10a56b15525d58c447810f53c3e1c35a", "parents": [ "dbb23ec93454284381b98bee9284160ed2c67a51" ], "author": { "name": "Keith Randall", "email": "khr@golang.org", "time": "Mon Jun 16 13:22:10 2025 -0700" }, "committer": { "name": "Keith Randall", "email": "khr@google.com", "time": "Mon Jun 16 15:22:56 2025 -0700" }, "message": "internal/gocore: handle moving direct interface flag from kind to tflag\n\nChange-Id: I2b8cf8030c7041bfef22a57adf49da2e5e1ebf8a\nReviewed-on: https://go-review.googlesource.com/c/debug/+/682075\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "dbb23ec93454284381b98bee9284160ed2c67a51", "tree": "e211a35b2b89051e11ac3b9557561358fc42068f", "parents": [ "6797edac53ce5618710f8e91d3939658adc34ef1" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon May 05 06:02:03 2025 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon May 05 11:12:43 2025 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I36abdb04ba8782c4b81ad468ba8c200c322875a0\nReviewed-on: https://go-review.googlesource.com/c/debug/+/669915\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "6797edac53ce5618710f8e91d3939658adc34ef1", "tree": "b809d73249298ac925bced3e7c13608f2ddf2c3d", "parents": [ "08f59666f592c93ffd8141e8bfe580fd03985608" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat Apr 05 06:01:50 2025 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat Apr 05 17:33:39 2025 -0700" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Ia9e0d6a318551b3f5092c7ee74df3326f079d36d\nReviewed-on: https://go-review.googlesource.com/c/debug/+/663115\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "08f59666f592c93ffd8141e8bfe580fd03985608", "tree": "8a06c929c4bb7088b350ce661fcca64682222a02", "parents": [ "82d29c988d410c36245e61a4cb9812e056a2c06f" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Fri Mar 21 03:26:08 2025 +0000" }, "committer": { "name": "Michael Knyszek", "email": "mknyszek@google.com", "time": "Tue Mar 25 09:29:51 2025 -0700" }, "message": "gocore: support typing composite roots\n\nThis change adds support for composite roots to typeHeap, which should\nmake it possible to type more of the heap.\n\nChange-Id: I7757f23bf18375160c4f2607efd290aeeb89ec93\nReviewed-on: https://go-review.googlesource.com/c/debug/+/659797\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "82d29c988d410c36245e61a4cb9812e056a2c06f", "tree": "4dc5af02c293fa5c7a3b6b507b9d2438c306a0c0", "parents": [ "5ed60df39fedfd6fc91ad91993c5bd480011b273" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Fri Mar 21 02:50:12 2025 +0000" }, "committer": { "name": "Michael Knyszek", "email": "mknyszek@google.com", "time": "Tue Mar 25 09:29:44 2025 -0700" }, "message": "gocore: expand bigslice test to test deconstructed values on the stack\n\nChange-Id: Ie525b23748a53fffd9876515ebf2caa93744f523\nReviewed-on: https://go-review.googlesource.com/c/debug/+/659796\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\n" }, { "commit": "5ed60df39fedfd6fc91ad91993c5bd480011b273", "tree": "749a0e4993d0fb1c0b1d4530767bab4f192b534e", "parents": [ "c0c48f591b7e557d721390b8035c530a588f52fd" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Thu Mar 20 20:15:06 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Mar 24 09:05:26 2025 -0700" }, "message": "gocore: break up test to make it more understandable\n\nAlso, remove unused test code and add common elements between the test\nprograms to testenv.\n\nChange-Id: Ib5c8e2d1768016df54f3212d79ec9542492367dd\nReviewed-on: https://go-review.googlesource.com/c/debug/+/659795\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\n" }, { "commit": "c0c48f591b7e557d721390b8035c530a588f52fd", "tree": "2a16ad4f1c6117067ac4c72491c8a68257a7d815", "parents": [ "2ce4b6f20c9a97cab94a86f65d49f3a8cb737995" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Wed Mar 19 16:43:21 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Mar 24 09:03:13 2025 -0700" }, "message": "gocore: add missing append in root piece construction\n\nCurrently when constructing a Root from a stack variable, we compute all\nthe pieces of the stack variable, and intend to store those pieces along\nwith the root. Except, the code is currently buggy and doesn\u0027t actually\nappend to the slice of pieces. Oops. Add in the append, which suddenly\nmakes a whole bunch of stack variables visible.\n\nChange-Id: I0ae7577aa3959f72c0641711aa3799b3708447a0\nReviewed-on: https://go-review.googlesource.com/c/debug/+/659336\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nCommit-Queue: Michael Knyszek \u003cmknyszek@google.com\u003e\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "2ce4b6f20c9a97cab94a86f65d49f3a8cb737995", "tree": "bf7181a1207dcb7bd9af903f1a74efa528189d87", "parents": [ "70c1efa92f35c3fd915affb07fa80222df26cabd" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Wed Mar 19 16:41:52 2025 +0000" }, "committer": { "name": "Michael Knyszek", "email": "mknyszek@google.com", "time": "Wed Mar 19 14:11:57 2025 -0700" }, "message": "gocore: fix bad processing of large object pointers\n\nCurrently large object pointer finding has a bug in that we don\u0027t\ninterpret largeType as an array element type (which it is) and instead\nas the single type for the entire array. This means we miss lots of\npointers in large objects that are, for example, a slice of pointers.\n\nChange-Id: I9ade197b5db9ac52b829524e0d70822c8fdc1dbf\nReviewed-on: https://go-review.googlesource.com/c/debug/+/659335\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\n" }, { "commit": "70c1efa92f35c3fd915affb07fa80222df26cabd", "tree": "f336fc5141a760057a3b786913e6e41c4d644e9c", "parents": [ "9a1a32438088c06bc20080d7c7eb76f2017515c4" ], "author": { "name": "Derek Parker", "email": "parkerderek86@gmail.com", "time": "Fri Mar 14 01:52:55 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat Mar 15 14:19:49 2025 -0700" }, "message": "dwtest: add test for go#72053\n\nAdds a test for https://go.dev/issue/72053\nNote the fix is submitted as https://go.dev/cl/656736\n\nFor [golang/go#72053](https://github.com/golang/go/issues/72053)\n\nChange-Id: Iea247439f95cce85bf9a1560dd475be5048ec97a\nGitHub-Last-Rev: dcd050f0539dc6c11d75ae7a9da197aa99fe6c01\nGitHub-Pull-Request: golang/debug#22\nReviewed-on: https://go-review.googlesource.com/c/debug/+/657355\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "9a1a32438088c06bc20080d7c7eb76f2017515c4", "tree": "f946fb3e4cbe6e6f565cdd2492615a4a7df547fd", "parents": [ "84fb7c842f99eb20a3d52bd9db6a557f77b29669" ], "author": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Mon Mar 03 14:51:53 2025 -0500" }, "committer": { "name": "Michael Knyszek", "email": "mknyszek@google.com", "time": "Wed Mar 05 09:41:39 2025 -0800" }, "message": "dwtest: upgrade delve dependency in testdata to pull in DWARF5 support\n\nUpdate the go.mod + go.sum for the \u0027dwdumploc\u0027 helper program\nthat we build and run as part of this test. The main most recent\ncommits on delve tip include DWARF5 fixes that we need.\n\nUpdates golang/go#26379.\n\nChange-Id: Ieafd0a7f5c5cb74f912a9cefa26408ae9d5548e5\nReviewed-on: https://go-review.googlesource.com/c/debug/+/654356\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\n" }, { "commit": "84fb7c842f99eb20a3d52bd9db6a557f77b29669", "tree": "2f031fa7159380c4e2f5be0bcc66275b0dfa8260", "parents": [ "8850c750f7b36c63ac755ebb384ff07a46f015f1" ], "author": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Sun Mar 02 14:21:44 2025 -0500" }, "committer": { "name": "Michael Knyszek", "email": "mknyszek@google.com", "time": "Wed Mar 05 09:41:25 2025 -0800" }, "message": "internal/gocore: support for DWARF version 5 location lists\n\nRework the DWARF reading code to handle location lists in DWARF 5\nformat in addition to the existing DWARF 2/4 code.\n\nUpdates golang/go#26379.\n\nChange-Id: I9d502f5bcecc752e4c1fe7cfaa9ff5871fe417de\nReviewed-on: https://go-review.googlesource.com/c/debug/+/654256\nReviewed-by: Junyang Shao \u003cshaojunyang@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\n" }, { "commit": "8850c750f7b36c63ac755ebb384ff07a46f015f1", "tree": "43e2be376466a9cb3e49def2fef9144d9e7da0d0", "parents": [ "1e0cbda3cf35577dcef678607bbb0d721a874557" ], "author": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Sun Mar 02 14:19:33 2025 -0500" }, "committer": { "name": "Michael Knyszek", "email": "mknyszek@google.com", "time": "Wed Mar 05 09:41:18 2025 -0800" }, "message": "third_party/delve/dwarf: refresh to add support for DWARF 5\n\nThis patch pulls in some additional pieces from Delve that add support\nfor DWARF 5. Prior to this point the code copied from delve here was\nspecific to DWARF 2; once the Go compiler starts generating DWARF\nversion 5 we need more machinery to handle that.\n\nUpdates golang/go#26379.\n\nChange-Id: Ib7bee1101101459e8eb5f7c62c625f0b7b53411f\nReviewed-on: https://go-review.googlesource.com/c/debug/+/654255\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nReviewed-by: Junyang Shao \u003cshaojunyang@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "1e0cbda3cf35577dcef678607bbb0d721a874557", "tree": "a2bfce2f5fd86d75e68cf75abafa683f057b1e41", "parents": [ "04bfb7cc7686bfca056617be8302bd7f865b00fc" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Mar 05 05:01:42 2025 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Mar 05 07:52:46 2025 -0800" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I67a13c0a6afd84f005bb113b62659858cc22e24b\nReviewed-on: https://go-review.googlesource.com/c/debug/+/655015\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "04bfb7cc7686bfca056617be8302bd7f865b00fc", "tree": "2ee433eeec2e006a032a909d3ec42de166678e8f", "parents": [ "6e468398a174c88e4c8dc252ea5ade769a2ff387" ], "author": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Sun Dec 29 12:16:39 2024 -0500" }, "committer": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Sun Feb 23 12:08:16 2025 -0800" }, "message": "internal/gocore: fixes for DWARF5 support\n\nFix some DWARF-related test code to allow for subprogram DIE high_pc\nattrs that are offsets from low_pc as opposed to addresses themselves\n(this is what the Go compiler will be doing when it generates DWARF5).\n\nUpdates golang/go#26379.\n\nChange-Id: I9d7bde7bbc305e01b0e8b61f3f2ed079c987274d\nReviewed-on: https://go-review.googlesource.com/c/debug/+/639177\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "6e468398a174c88e4c8dc252ea5ade769a2ff387", "tree": "60ca3f81d25d7beba99be21c0e54684504364aec", "parents": [ "4c9cba112488790c1707e093de24fc2d7607efa1" ], "author": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Mon Dec 16 12:46:21 2024 -0500" }, "committer": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Sun Feb 23 12:08:11 2025 -0800" }, "message": "dwtest: fixes for DWARF5 support\n\nFix the var location test harness to allow for subprogram DIE high_pc\nattrs that are offsets from low_pc as opposed to addresses themselves\n(this is what the Go compiler will be doing when it generates\nDWARF5). Also add \"-trimpath\" to a number of the builds to make it\neasier to diff good/bad DWARF.\n\nUpdates golang/go#26379.\n\nChange-Id: I708e14e5bb60ba4ebd668e616c4ca37f8d998efc\nReviewed-on: https://go-review.googlesource.com/c/debug/+/636518\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "4c9cba112488790c1707e093de24fc2d7607efa1", "tree": "9bfa11211bde045afe3aabbbaa59e55ff0129f45", "parents": [ "9ba41c6eb8c24e41ad7169376d2ac01d7b21864d" ], "author": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Fri Jan 03 18:59:50 2025 -0500" }, "committer": { "name": "Than McIntosh", "email": "thanm@golang.org", "time": "Sun Feb 23 12:08:01 2025 -0800" }, "message": "dwtest: sync with main Go repo to pull in DWARF5 support func\n\nCopy in the latest version of the support file dwtest.go, so as\nto incorporate a new support function \"SubprogLoAndHighPc\" that is\nuseful when dealing with DWARF5.\n\nUpdates golang/go#26379.\n\nChange-Id: Icadcab3e33ea40d308fc0068f87c683d2d5eb1bc\nReviewed-on: https://go-review.googlesource.com/c/debug/+/640255\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\n" }, { "commit": "9ba41c6eb8c24e41ad7169376d2ac01d7b21864d", "tree": "85059dc50692c15dc1e08bbdf20673a6fe666924", "parents": [ "aabb5e0f5ac8858fdea71192a5594f2dfb39bc2b" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Feb 14 20:38:46 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Feb 14 12:50:07 2025 -0800" }, "message": "all: upgrade go directive to at least 1.23.0 [generated]\n\nBy now Go 1.24.0 has been released, and Go 1.22 is no longer supported\nper the Go Release Policy (https://go.dev/doc/devel/release#policy).\n\nFor golang/go#69095.\n\n[git-generate]\n(cd . \u0026\u0026 go get go@1.23.0 \u0026\u0026 go mod tidy \u0026\u0026 go fix ./... \u0026\u0026 go mod edit -toolchain\u003dnone)\n\nChange-Id: Ibe84e05e8e72e6670d901ebf498216d0945b8d3f\nReviewed-on: https://go-review.googlesource.com/c/debug/+/649755\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "aabb5e0f5ac8858fdea71192a5594f2dfb39bc2b", "tree": "bab953ee923c9e588ec155728fc9900162eeca3a", "parents": [ "bb5bb2484ff32e139320c1c2d8718903089c91d9" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Feb 04 06:18:42 2025 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Feb 04 07:49:29 2025 -0800" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I91dfb94ee6a908ad9863d1e7ffd4aa1c64dc9a9e\nReviewed-on: https://go-review.googlesource.com/c/debug/+/646476\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "bb5bb2484ff32e139320c1c2d8718903089c91d9", "tree": "f9610cedff679efee15ce51bf6e175f51c86bfcf", "parents": [ "b341049684da5bace4625c231b50de1ef2e6a453" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Wed Jan 08 20:20:00 2025 +0000" }, "committer": { "name": "Michael Knyszek", "email": "mknyszek@google.com", "time": "Fri Jan 10 09:17:27 2025 -0800" }, "message": "gocore: skip nil largeType when discovering pointers\n\nIf a core is taken while a goroutine is allocating a large object (which\nis more likely than smaller objects, because zeroing is delayed and\ntakes longer than for smaller objects) gocore might observe a nil\nlargeType in the span, which is left nil to prevent the GC from trying\nto scan the partially-initialized object.\n\nFixes golang/go#71182.\n\nChange-Id: Iafa7aed29466dc8ad6eac8f10171885421e10f76\nReviewed-on: https://go-review.googlesource.com/c/debug/+/641515\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "b341049684da5bace4625c231b50de1ef2e6a453", "tree": "c5a5de540312e5c0a0d6abc127459baf8e343502", "parents": [ "1b463205dc9a0f87a8439d95225891d6242711b5" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat Jan 04 06:45:13 2025 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat Jan 04 17:15:01 2025 -0800" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I859fcf1aaaecaedffd4ca8631acbb6192cb947c3\nReviewed-on: https://go-review.googlesource.com/c/debug/+/640358\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "1b463205dc9a0f87a8439d95225891d6242711b5", "tree": "c7dd51bd39121c1752a458ae31f8cbdef9ffe8f5", "parents": [ "453fb03fae2cddf2a8a275056f12c8290341734c" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Thu Dec 19 17:38:58 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Dec 19 12:27:00 2024 -0800" }, "message": "gocore: record global pointers not described in DWARF as roots\n\nCurrently globals are entirely defined by what we can find in DWARF, but\nthere are some globals (for example, runtime..interfaceSwitch.0) which\nhave no corresponding DWARF. This is problematic, because markObjects\nuses the full set of global pointers *instead of* the roots we found to\nmark objects. This is more precise, but creates a discrepancy, and\ncallers (such as the dominator functionality) can\u0027t actually find a path\nto all listed objects.\n\nFix this by walking all these undescribed global pointers and recording\nthem explicitly as \"unknown\" roots. This makes viewcore much more robust\nto future changes, at the expense of not being able to type the\nundescribed things it finds.\n\nThis change also refactors ForEachRootPtr\u0027s internals into something\nthat could be executed from markObjects, and refactors markObjects to be\nsimpler and use the Process APIs.\n\nGoroutine stack roots already do this, but globals do not, causing\ncertain intuitive invariants (like that each object in ForEachObject\nshould be reachable from ForEachRoot) to be violated.\n\nChange-Id: Ie170098e5e5df929bbef5dee47b068de213a89a4\nReviewed-on: https://go-review.googlesource.com/c/debug/+/637876\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\n" }, { "commit": "453fb03fae2cddf2a8a275056f12c8290341734c", "tree": "eaaf58e2411570dac5f6b8b063fe4392b9349bbc", "parents": [ "71db9462eb994327a79928fbbaee3f3675458df1" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Wed Dec 18 06:08:59 2024 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Dec 19 12:26:58 2024 -0800" }, "message": "gocore: explicitly load symbols from executable ELF file\n\nThis fixes partial typing fails when the core in question is complete\n(meaning: no section has Filesz !\u003d Memsz). Such cores can be triggered\non Linux by writing (see core(5)):\n\n echo 0x3f \u003e /proc/self/coredump_filter\n\nIn this case, none of the mem mappings are backed by the executable file\non disk. This meant that the previous readSymbols implementation only\nreads the core file (which it ignored anyway).\n\nInstead of looping over the mappings, read the symbols explicitly from\nthe executable.\n\nI added a test which fails before my change. I had to refactor the\ntesting code a little bit to make it easier to pass an environment\nvariable. Unfortunately, changing /proc/self/coredump_filter means\nwriting to a file. Pulling in a dependency on package os makes the\ndominator tests panic. For now I\u0027ve disabled these tests: we\u0027re not sure\nit worked well anyway (it must have crashed for non-trivial programs).\nThere may need to be more improvements in general typing/walking before\nre-enabling it. In principle, the dominator failure could be partially\navoided by using build tags and not running the dominator test when\ncoredump_filter doesn\u0027t need to be manipulated. But given what I wrote\nbefore, I don\u0027t see why we should bother.\n\nThe history of this is interesting:\n\n - https://go.dev/cl/137375 is the last good change to this part of the\n code. It reads symbols from all loaded executables. Its CL\n description mentions that this is required for PIE and mixed (e.g.:\n Go/C++ binaries). Yet the PIE and (internal) mixed binary tests\n continue to pass with this change:\n\n - I found that PIE support didn\u0027t work and added it in\n https://go.dev/cl/618977 (with tests). Perhaps this is a reference\n to PIE support that was somehow removed in-between.\n - viewcore does not explicitly support mixed binaries, in the sense\n that it does not (attempt) to understand C objects. The PIE tests\n\n - https://go.dev/cl/506558 introduced the full core bug by replacing\n the read from all executable files with an iteration of the mappings.\n\nChange-Id: I2538cd863da72a9ebfc9415b32a97bf962479b61\nReviewed-on: https://go-review.googlesource.com/c/debug/+/637415\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\n" }, { "commit": "71db9462eb994327a79928fbbaee3f3675458df1", "tree": "5427bdba38d2605b94965fdd44ba5a9103e674f7", "parents": [ "5f2bbc1069aecbc97fce688b2feafecb0eedfe86" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Fri Dec 13 20:24:29 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Dec 16 13:41:15 2024 -0800" }, "message": "gocore: overhaul roots, expand testing\n\nThis change overhauls how roots work to prepare for supporting composite\nvalues (roots \"de-structured\" and broken up into pieces, despite\nrepresenting a single type). It also expands testing a little bit to\nprevent backsliding from this point.\n\nRoots now do not have an address identity at all, and callers do not\nrely on that fact anymore. They have a forged identity which is useful\nfor some calculations, but otherwise can only be identified by a *Root.\n\nPointers may now be found in composite roots, which is nice, so all\ndestructured values work correctly for the sake of iterating over all\npointers.\n\nFinally, this fixes a small, old bug in typeObject where the type\npointer would be interrogated before we filtered out whether a interface\nwas nil or not. Because we filter dead pointers by making them appear\nnil, this means we could end up looking at a bogus, clobbered type\npointer. (This may be a bug in the compiler\u0027s DWARF generation, the type\nshouldn\u0027t be clobbered.)\n\nChange-Id: I09217b2070dc6f4bf4b1dbd28d52f570ba61ca4a\nReviewed-on: https://go-review.googlesource.com/c/debug/+/635857\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "5f2bbc1069aecbc97fce688b2feafecb0eedfe86", "tree": "18e528d882bd1c801340777c222b01ca910331df", "parents": [ "46b335ef7eef4cee8044985a958042a0fa53ccd5" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Fri Dec 13 07:23:39 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Dec 16 13:41:12 2024 -0800" }, "message": "gocore: use dwarf-\u003eabi.Type map and type-walk deeper for direct ifaces\n\nThis change makes two major changes to typing the heap.\n\n1. It matches up DWARF names to internal/abi.Type addresses via the\n DW_AT_Go_runtime_type attribute, which links the internal/abi.Type\n address to the DWARF entry for a type. This allows us to fully and\n unambiguously give every type an identity.\n\n2. It fixes what appears to be a minor bug in the type-walk: direct\n interfaces that contain pointers (type is a *T and the data is also\n a *T or a [1]*T or a struct{ *T }) were passed on as interior\n pointers to the walk queue, but this could easily result in\n unmergable interior chunks and loss of type information. Instead, we\n know it\u0027s a pointer type then and there, and we can just walk it\n directly, queuing up the pointed-to type instead. This makes the\n type-walk just a little more precise.\n\nChange-Id: I8842cdef5e92596c3c0b1365c5f5297604b83113\nReviewed-on: https://go-review.googlesource.com/c/debug/+/635737\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "46b335ef7eef4cee8044985a958042a0fa53ccd5", "tree": "3a8587aa54b4a81768ffe8460b37751dca39fd7e", "parents": [ "96bf9a98636638d6f9f2421fa5a3439a44ef60bc" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Thu Dec 12 22:14:13 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Dec 13 01:12:30 2024 -0800" }, "message": "gocore: more fixes for Go 1.24\n\n- The isCrashFrame flag during unwinding was never reset, which could\n be bad.\n- We\u0027re apparently reading a lot of stale constants and not seeing it\n because a failed read from the constants map just returns the zero\n value. Oops! Add a much stricter map wrapper type for constants and\n fix up all the stale constants. This fixes a whole bunch of things,\n including totally incorrect readings of the liveness maps.\n- More strict checking of liveness map data.\n\nChange-Id: I2cb4901df4e3f473ef8b0c09981ba222e883b0b6\nReviewed-on: https://go-review.googlesource.com/c/debug/+/635835\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nCommit-Queue: Nicolas Hillegeer \u003caktau@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\n" }, { "commit": "96bf9a98636638d6f9f2421fa5a3439a44ef60bc", "tree": "786082240098805e82ccfe1b781e53be55f0d2f3", "parents": [ "3793491ddf6aae5faeba509ae6b69b6e612c48b3" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Thu Dec 12 18:15:44 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Dec 12 10:47:51 2024 -0800" }, "message": "gocore: add in mpratt\u0027s feedback and remove delve dependency\n\nThis change integrates some feedback from mpratt in CL 635227 that came\nin after it landed. It also removes the dependency on delve, since this\nis definitely reaching into internal packages that are not intended to\nbe used by outsiders. Instead, we just copy over what we need. This is\nsafe to copy over because it\u0027s largely about immutable formats and\nfunctionality: hardware register names and DWARF 2.\n\nChange-Id: I5aa8cb9a56b464c0cdb45baf4ea8423989d0afbe\nReviewed-on: https://go-review.googlesource.com/c/debug/+/635281\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\n" }, { "commit": "3793491ddf6aae5faeba509ae6b69b6e612c48b3", "tree": "64b770770bf2caf56921973a65f5cc5263d43dff", "parents": [ "3c468bb2d1418915136f9e36f044ac6672914836" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Tue Dec 10 19:41:07 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Dec 12 01:11:06 2024 -0800" }, "message": "gocore: update for Go 1.24\n\nThis change drops support for old versions of Go and adds numerous\nupdates to support Go 1.24.\n\n- Correct DWARF variable parsing via location lists and complete\n interpretation of DWARF expressions (with the help of a couple\n Delve packages).\n- Fixed handling of sigtrampgo and unwinding out of the signal handler.\n- Improved handling of frames that aren\u0027t in safe points by\n conservatively finding live pointers through DWARF types of live\n local variables.\n- Partial support for values live in registers (much more to do here,\n and composites are not supported).\n- Completely overhauled Process initialization to better track\n dependencies.\n- Clean up of \"page table\" data structure to be better encapsulated and\n more explicitly about the heap.\n- Fix for a field in a runtime.special moving from a uint16 to a\n uintptr.\n- Overhaul of gocore.Stats -\u003e gocore.Statistic.\n- Update go.mod to go1.23 for iterators.\n- Update some dependencies.\n- Adds TestObject from go.dev/cl/634756 (thanks aktau@!).\n\nThe main milestone this CL reaches is that the main.Large value in the\ncore test is consistently found and correctly typed.\n\nThere is still a lot left to do.\n\n- Anything interpreting map structure is completely wrong with\n the change to Swiss Tables.\n- Full support for roots that are in registers. (This matters, because\n otherwise values that are only in a register in the crash context are\n completely missed.)\n- Full support for values that are partially in registers (composites).\n- Tons of cleanup.\n- A better abstraction over arches (so much stuff is hard-coded for\n amd64).\n\nChange-Id: I9c671c15128b72ee118b3623aa403477b91f5ce6\nReviewed-on: https://go-review.googlesource.com/c/debug/+/635227\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nCommit-Queue: Nicolas Hillegeer \u003caktau@google.com\u003e\n" }, { "commit": "3c468bb2d1418915136f9e36f044ac6672914836", "tree": "a4258665b4d92fb532ad3a92a977390494ee5ad9", "parents": [ "acddda48f7cd6c8a5e18ceba7fac3eae77d604ae" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Mon Dec 09 08:57:01 2024 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Dec 10 15:53:05 2024 +0000" }, "message": "internal/gocore: find new names of runtime._type and runtime.itab\n\nThis change makes (e.g.) `viewcore histogram` run without crashing cores\nproduced by current toolchains again. The output is still partially\nwrong, in the sense that it outputs a mixture of named and unnamed\ntypes:\n\n runtime.g size\u003d448\n []*runtime.moduledata size\u003d24\n [1+1?]*runtime.moduledata size\u003d16\n [10+6?]uint8 size\u003d16\n [1+3?]uint32 size\u003d16\n\nStill it\u0027s an improvement over the status quo.\n\nIn Go 1.21, runtime._type was converted from its own type into an alias\nof internal/abi.Type. In the process, its fields became public too. For\nan overview of the history:\n\n - https://go.dev/cl/462995 (internal/abi: refactor (basic) type struct into one definition)\n - https://go.dev/cl/484856 (internal/reflectlite, runtime: move more constants and types into internal/abi)\n - https://go.dev/cl/488435 (runtime: redefine _type to abi.Type; add rtype for methods)\n\nIn https://go.dev/cl/608475 (internal/gocore: support Go 1.22 allocation\nheaders), this was partially reflected in viewcore, but only just enough\nto get basic tests for the current toolchain working.\n\nThere were still references to the old `runtime._type` and\n`runtime.itab` (renamed `abi.ITab`), causing crashes for certain\noperations, like `viewcore histogram` as well as the nascent dominator\ntree code:\n\n panic: can\u0027t find type runtime._type [recovered]\n panic: can\u0027t find type runtime._type\n\n golang.org/x/debug/internal/gocore.(*Process).findType(...)\n /home/aktau/go/debug/internal/gocore/process.go:112\n golang.org/x/debug/internal/gocore.(*Process).runtimeType2Type(0xc00026a000, 0x46d8a0, 0x4ee3a8)\n /home/aktau/go/debug/internal/gocore/type.go:153 +0x14d9\n golang.org/x/debug/internal/gocore.(*Process).typeObject(0xc00026a000, 0x4ee3a0, 0xc000392460, {0x7b9e40, 0xc0001f4000}, 0xc00052d960)\n /home/aktau/go/debug/internal/gocore/type.go:636 +0xd45\n golang.org/x/debug/internal/gocore.(*Process).typeHeap.func1.2(0xc000582a08?)\n /home/aktau/go/debug/internal/gocore/type.go:514 +0x79\n golang.org/x/debug/internal/gocore.(*Process).ForEachRoot(0xc00026a000, 0xc00052db20)\n /home/aktau/go/debug/internal/gocore/object.go:220 +0x6a\n golang.org/x/debug/internal/gocore.(*Process).typeHeap.func1()\n /home/aktau/go/debug/internal/gocore/type.go:509 +0x179\n sync.(*Once).doSlow(0x6fe760?, 0xc00026a000?)\n /usr/lib/google-golang/src/sync/once.go:76 +0xb4\n sync.(*Once).Do(...)\n /usr/lib/google-golang/src/sync/once.go:67\n golang.org/x/debug/internal/gocore.(*Process).typeHeap(0x3?)\n /home/aktau/go/debug/internal/gocore/type.go:383 +0x3b\n golang.org/x/debug/internal/gocore.runLT(0xc00026a000)\n /home/aktau/go/debug/internal/gocore/dominator.go:89 +0x58\n golang.org/x/debug/internal/gocore.TestVersions.func2.1(0xc00012c680)\n /home/aktau/go/debug/internal/gocore/gocore_test.go:513 +0x5e\n\nChange-Id: I8559c86f03d52b114f92756caf4487df75237983\nReviewed-on: https://go-review.googlesource.com/c/debug/+/634755\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nCommit-Queue: Nicolas Hillegeer \u003caktau@google.com\u003e\n" }, { "commit": "acddda48f7cd6c8a5e18ceba7fac3eae77d604ae", "tree": "93caedf867c92c1d8ef6d2ceb9f7065d6274b404", "parents": [ "af4ac2cfe2afaf227ce4f93a97dabea0edf00a08" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Dec 04 14:01:50 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Dec 04 16:04:52 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I921a4d5f47e510f3e96da434dab26a8e3e8fbf84\nReviewed-on: https://go-review.googlesource.com/c/debug/+/633576\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "af4ac2cfe2afaf227ce4f93a97dabea0edf00a08", "tree": "4f2d3d5d4b1c83403fa32c15cb6098aadb877423", "parents": [ "885ca4e683954f93f6eda2e85726e3b275e234f5" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Wed Nov 27 14:28:28 2024 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Dec 02 21:20:15 2024 +0000" }, "message": "internal/gocore/test: split run into runCrasher and doRunCrasher\n\nRefactors the run function by splitting it in two, making it easier to\nreuse for more involved tests that need to set different parameters\n(flags, other environment variables).\n\nThis commit also makes the otherwise unrelated change of setting\nGOMAXPROCS\u003d2 in the child binary. This can reduce the size of the crash\nstack (fewer GC workers).\n\nChange-Id: I4edd5c51fdfed6b8bb57f2e682cb98dc084e50a5\nReviewed-on: https://go-review.googlesource.com/c/debug/+/632296\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\n" }, { "commit": "885ca4e683954f93f6eda2e85726e3b275e234f5", "tree": "a40af312e32ecb6b885f92fddb91ef451e307851", "parents": [ "7033794ba9b34167ce05c6569d3fd6f1f6492555" ], "author": { "name": "Ian Lance Taylor", "email": "iant@golang.org", "time": "Tue Nov 05 11:31:06 2024 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Nov 12 18:37:18 2024 +0000" }, "message": "README: mention the git repo\n\nChange-Id: I7c8bfa41bf29c42fa20478f0ba51f5d74f035876\nReviewed-on: https://go-review.googlesource.com/c/debug/+/625675\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\nCommit-Queue: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Robert Findley \u003crfindley@google.com\u003e\n" }, { "commit": "7033794ba9b34167ce05c6569d3fd6f1f6492555", "tree": "279417df1de7974559bf443bddebdbe80c28ed19", "parents": [ "7c4558292c671977645c344ac3b5760cfe11147d" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Nov 07 21:05:40 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Nov 07 21:28:02 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Iae212f59b7d54afe91226425d544007c0eb5716d\nReviewed-on: https://go-review.googlesource.com/c/debug/+/626356\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "7c4558292c671977645c344ac3b5760cfe11147d", "tree": "f8fba1479dec5953f1dd61517e57b3c355201d7e", "parents": [ "dfd7e92aa331f2d584bfefaab2d0432a1bb8c91d" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Sat Oct 12 14:59:46 2024 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Oct 14 01:08:16 2024 +0000" }, "message": "internal/gocore: fix large types dereference (Go 1.22+)\n\nviewcore supports Go 1.22+ allocation headers since CL 608475. The CL\ndescription mentions:\n\n\u003e This gets the goroot test passing again, which is a low bar... but\n\u003e it\u0027s something.\n\nThis CL fixes an untested path, and modifies test.go to hit that path by\nallocating a \"large\" object (\u003e32760 bytes). When allocating a large\nobject, viewcore panics:\n\n```\npanic: asking for field of non-struct [recovered]\n panic: asking for field of non-struct\n\ngoroutine 170 [running]:\ntesting.tRunner.func1.2({0x72ce80, 0x7b86c0})\n /usr/lib/google-golang/src/testing/testing.go:1632 +0x230\ntesting.tRunner.func1()\n /usr/lib/google-golang/src/testing/testing.go:1635 +0x35e\npanic({0x72ce80?, 0x7b86c0?})\n /usr/lib/google-golang/src/runtime/panic.go:785 +0x132\ngolang.org/x/debug/internal/gocore.(*Type).field(...)\n /usr/local/google/home/aktau/gob/go/debug/internal/gocore/type.go:85\ngolang.org/x/debug/internal/gocore.region.Field(...)\n /usr/local/google/home/aktau/gob/go/debug/internal/gocore/region.go:163\ngolang.org/x/debug/internal/gocore.(*Process).readSpans(0xc0001fe000, {0xc0001fe000?, 0xc000000f50?, 0xc000000500?}, {0xc000aa0480?, 0x1, 0xc0005d7260?})\n /usr/local/google/home/aktau/gob/go/debug/internal/gocore/process.go:596 +0x5125\ngolang.org/x/debug/internal/gocore.(*Process).readHeap(0xc0001fe000)\n /usr/local/google/home/aktau/gob/go/debug/internal/gocore/process.go:254 +0x569\ngolang.org/x/debug/internal/gocore.Core(0xc0001f4000)\n```\n\nIndeed, `largeType` is not a struct, but a pointer to a struct:\n\n```\n// src/runtime/mheap.go\ntype mspan struct {\n\t_ sys.NotInHeap\n\t// ...\n\tlargeType *_type // malloc header for large objects.\n}\n```\n\nAdd a `Deref()` operation to fix this. Afterwards, the test does not panic\nanymore. Though no attempt has been made to verify that the results are good.\n\nChange-Id: I3569e5e1fba14a311507944f75e2ee2d27616a15\nReviewed-on: https://go-review.googlesource.com/c/debug/+/619875\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\n" }, { "commit": "dfd7e92aa331f2d584bfefaab2d0432a1bb8c91d", "tree": "bf43890a4c6c181608fcff8a03eb8fb977409b18", "parents": [ "5a189bc297f7bfd286854af560f3b82c4e81bd20" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Thu Oct 10 14:29:44 2024 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Oct 11 14:49:41 2024 +0000" }, "message": "internal/gocore/test: increase rlimit to max in parent\n\nIn our CI system, RLIMIT_CORE\u0027s maximum value is not `unlimited`. So\n`setrlimit(RLIMIT_CORE, {...RLIM_INFINITY})` fails. Instead set it to\nthe maximum and ensure that it\u0027s not 0. A core file, even if truncated,\nshould get created.\n\nAdditionally, move the rlimit increase to the parent instead of the\nchild. This makes it easier to add more test binaries without\nduplicating code. To make this stick, wrap the spawn with\n`(Un)LockOSThread`.\n\nThe new `run()` function returns a PID, which isn\u0027t necessary here, but\nis useful in case `/proc/sys/kernel/core_pattern` contains format\nmodifiers like %p, as happens in our CI.\n\nChange-Id: Ied3533e0910dde2df888e50ca88c607ef33afacc\nReviewed-on: https://go-review.googlesource.com/c/debug/+/619555\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\n" }, { "commit": "5a189bc297f7bfd286854af560f3b82c4e81bd20", "tree": "1530c529280d2de3c1b23b50e0fa5c69758f6b65", "parents": [ "a0ffd1005ce9b0c8f93daa6fd675fe1cd072a084" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Thu Oct 10 16:01:11 2024 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Oct 10 23:27:56 2024 +0000" }, "message": "internal/gocore: ignore execute-only mappings\n\nCurrently viewcore panics when seeing an execute-only (`--xp`) mapping.\nBut such mappings do exist. From /proc/self/smaps in a process on one of\nour machines:\n\n ffffffffff600000-ffffffffff601000 --xp 00000000 00:00 0 [vsyscall]\n\nThis implies `vsyscall\u003dxonly` on that host. See\nhttps://lwn.net/Articles/790886/.\n\nChange-Id: I9299a53cfe07332e55fd7f6bed60f4a0f222293e\nReviewed-on: https://go-review.googlesource.com/c/debug/+/618981\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\n" }, { "commit": "a0ffd1005ce9b0c8f93daa6fd675fe1cd072a084", "tree": "3458520d24bf65a8239c8547347fc3343a506b21", "parents": [ "fdf0ed6f7420cefec0131eab86ba54755245fee2" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Wed Oct 09 07:45:08 2024 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 09 16:18:34 2024 +0000" }, "message": "internal/gocore: improve debug printing functions\n\nThese were nice when I was debugging why my changes to support PIE were\nnot working. Especially the `Perm` string is now both more compact and\nof static size.\n\nChange-Id: I18f2489b40c8087c7beebd088b97899223bec66e\nReviewed-on: https://go-review.googlesource.com/c/debug/+/618978\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "fdf0ed6f7420cefec0131eab86ba54755245fee2", "tree": "ade34da338c958f75b10e955fb23e78e686d65cd", "parents": [ "60d51dfed16480aef9c21690a1e1767c19dd9393" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Wed Oct 09 07:44:18 2024 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 09 16:02:30 2024 +0000" }, "message": "internal/gocore: support PIE ELF binaries\n\nGo binaries built with `-buildmode\u003dpie` are loaded at random addresses\n(ASLR) in memory by Linux.\n\nBefore this change, the mappings read from the `NT_NOTE` section of the\nELF binary matches the exe mappings:\n\n # From NT_NOTE:\n 0x400000-0x491000 ---- 593920 /tmp/TestVersionsgoroot#003207751013/001/test.exe+0x0\n 0x491000-0x54b000 ---- 761856 /tmp/TestVersionsgoroot#003207751013/001/test.exe+0x91000\n 0x54b000-0x556000 ---- 45056 /tmp/TestVersionsgoroot#003207751013/001/test.exe+0x14b000\n\n # From executable:\n 0x400000-0x491000 r-xp 593920 /tmp/TestVersionsgoroot#003207751013/001/test.exe+0x0\n 0x491000-0x54b000 r--p 761856 /tmp/TestVersionsgoroot#003207751013/001/test.exe+0x91000\n 0x54b000-0x555000 rw-p 40960 /tmp/TestVersionsgoroot#003207751013/001/test.exe+0x14b000\n 0x555000-0x579000 rw-p 147456 anon+0x-440\n\n # From core\n 0xc000000000-0xc000400000 rw-p 4194304 /tmp/TestVersionsgoroot#003207751013/001/core+0x32000\n 0x7f8b17c00000-0x7f8b19c00000 rw-p 33554432 /tmp/TestVersionsgoroot#003207751013/001/core+0x432000\n 0x7f8b29d80000-0x7f8b29d81000 rw-p 4096 /tmp/TestVersionsgoroot#003207751013/001/core+0x2432000\n 0x7f8b49d80000-0x7f8b49d81000 rw-p 4096 /tmp/TestVersionsgoroot#003207751013/001/core+0x2433000\n 0x7f8b5bc30000-0x7f8b5bc31000 rw-p 4096 /tmp/TestVersionsgoroot#003207751013/001/core+0x2434000\n 0x7f8b5e006000-0x7f8b5e007000 rw-p 4096 /tmp/TestVersionsgoroot#003207751013/001/core+0x2435000\n 0x7f8b5e466000-0x7f8b5e4c6000 rw-p 393216 /tmp/TestVersionsgoroot#003207751013/001/core+0x2436000\n 0x7f8b5e4c6000-0x7f8b5e5c6000 rw-p 1048576 /tmp/TestVersionsgoroot#003207751013/001/core+0x2496000\n 0x7f8b5e5c6000-0x7f8b5e5d7000 rw-p 69632 /tmp/TestVersionsgoroot#003207751013/001/core+0x2596000\n 0x7f8b5e657000-0x7f8b5e658000 rw-p 4096 /tmp/TestVersionsgoroot#003207751013/001/core+0x25a7000\n 0x7f8b5e6d7000-0x7f8b5e737000 rw-p 393216 /tmp/TestVersionsgoroot#003207751013/001/core+0x25a8000\n 0x7f8b5e737000-0x7f8b5e73b000 r--p 16384 /tmp/TestVersionsgoroot#003207751013/001/core+0x2608000\n 0x7f8b5e73b000-0x7f8b5e73d000 r-xp 8192 /tmp/TestVersionsgoroot#003207751013/001/core+0x260c000\n 0x7ffd88d3c000-0x7ffd88d5e000 rw-p 139264 /tmp/TestVersionsgoroot#003207751013/001/core+0x260e000\n\nAnd things worked fine. But, with PIE binaries, we see the following raw\naddresses when loading (e.g.):\n\n # From NT_NOTE:\n 0x563f53d35000-0x563f53dc7000 ---- 598016 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/test.exe+0x0\n 0x563f53dc7000-0x563f53e10000 ---- 299008 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/test.exe+0x92000\n 0x563f53e10000-0x563f53ea3000 ---- 602112 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/test.exe+0xdb000\n 0x563f53ea3000-0x563f53eaf000 ---- 49152 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/test.exe+0x16e000\n 0x7ff5d0deb000-0x7ff5d0dec000 ---- 4096 /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2+0x0\n 0x7ff5d0dec000-0x7ff5d0e11000 ---- 151552 /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2+0x1000\n 0x7ff5d0e11000-0x7ff5d0e1b000 ---- 40960 /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2+0x26000\n 0x7ff5d0e1b000-0x7ff5d0e1f000 ---- 16384 /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2+0x30000\n\n # From executable:\n 0x400000-0x492000 r-xp 598016 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/test.exe+0x0\n 0x492000-0x4db000 r--p 299008 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/test.exe+0x92000\n 0x4db000-0x56f000 rw-p 606208 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/test.exe+0xdb000\n 0x56f000-0x579000 rw-p 40960 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/test.exe+0x16f000\n 0x579000-0x59d000 rw-p 147456 anon+0x-460\n\n # From core\n 0xc000000000-0xc000400000 rw-p 4194304 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/core+0x3000\n 0x563f53d35000-0x563f53d36000 r-xp 4096 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/core+0x403000\n 0x563f53d36000-0x563f53dc7000 r-xp 593920 anon+0x0\n 0x563f53dc7000-0x563f53e10000 r--p 299008 anon+0x0\n 0x563f53e10000-0x563f53ea3000 r--p 602112 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/core+0x404000\n 0x563f53ea3000-0x563f53eaf000 rw-p 49152 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/core+0x497000\n 0x563f53eaf000-0x563f53ed2000 rw-p 143360 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/core+0x4a3000\n ...\n 0x7ff5d0deb000-0x7ff5d0dec000 r--p 4096 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/core+0x26a4000\n 0x7ff5d0dec000-0x7ff5d0e11000 r-xp 151552 anon+0x0\n 0x7ff5d0e11000-0x7ff5d0e1b000 r--p 40960 anon+0x0\n 0x7ff5d0e1b000-0x7ff5d0e1f000 rw-p 16384 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/core+0x26a5000\n 0x7fff34a26000-0x7fff34a48000 rw-p 139264 /tmp/TestVersionsgoroot-buildmode\u003dpie3327190927/001/core+0x26a9000\n\nThis caused two issues:\n\n 1. The mappings from the executable and the core were not unified\n properly done in `addProgMappings -\u003e splicedMemory.Add` due to the\n address ranges being different. Both existeded in the\n `splicedMemory` set. Normally, the core mappings would override the\n executable mappings when they overlap. To correct for this, add the\n load offset (`staticBase`) to the executable addresses.\n 2. DWARF data (contained in the executable) references the base\n addresses (for example, `allgs` is at 0x4003c4). Due to #1, a lookup\n *would not crash*, but it would read the location from the\n executable. In a PIE binary, such a lookup into the `.data` section\n would be a relocation, and be present in the binary as all zeroes\n (0x0). If #1 were fixed to offset by `staticBase` without fixing #2\n would result in a read from unmapped memory.\n\nInspiration was taken from the Delve commit that added PIE support for\nmultiple platforms/architectures in\nhttps://github.com/go-delve/delve/commit/025d47c6e96e8ab5a2d2c142ae554e760cddabf8.\n\nAlso add tests that this works. I verified that if the changes from\nnon-test files are omitted, the test fails.\n\nChange-Id: Ifa08f71e7ed22320b78bc6015554e997b8ae521d\nReviewed-on: https://go-review.googlesource.com/c/debug/+/618977\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\n" }, { "commit": "60d51dfed16480aef9c21690a1e1767c19dd9393", "tree": "bc32403079979b7bfd5b8771ec5a7fd3bf51dc64", "parents": [ "a1f165e1349eb0f5fc9b0c99b44c5a7c2ab93e91" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Tue Oct 08 02:17:06 2024 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 09 15:52:30 2024 +0000" }, "message": "internal/gocore: add sanity checking to TestVersions\n\nThis strengthens the guarantees about what viewcore(1) supports.\nSpecifically, we have binaries built with PIE which appear to load\nproperly (`Core(...)` doesn\u0027t return an error, but return (e.g.) zero\ngoroutines. Tests should fail if this happens, there\u0027s always at least\none goroutine.\n\nThe sanity checking functions are defined separately so we can re-use\nthem in a test extension patch where we supply several types of binaries\nbuilt with non-standard flags (and without the `go build` tool).\n\nChange-Id: I492724a7a9d371ce694829368c7dfb73066bb821\nReviewed-on: https://go-review.googlesource.com/c/debug/+/618976\nReviewed-by: Nicolas Hillegeer \u003caktau@google.com\u003e\nAuto-Submit: Nicolas Hillegeer \u003caktau@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nRun-TryBot: Nicolas Hillegeer \u003caktau@google.com\u003e\n" }, { "commit": "a1f165e1349eb0f5fc9b0c99b44c5a7c2ab93e91", "tree": "91dda59b0604047d538a38b5f03607af907c0e80", "parents": [ "cba42236e06032c2f4ff8cb1180f8937845d5d46" ], "author": { "name": "Nicolas Hillegeer", "email": "aktau@google.com", "time": "Tue Oct 08 01:48:36 2024 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 09 15:33:43 2024 +0000" }, "message": "internal/gocore/test: DRY core-loading block\n\nThis code was the same in four different places. At this point it seems\ncleaner to abstract it.\n\nChange-Id: I512c05232bd06f2a7d3524b7889ea3680b49afb5\nReviewed-on: https://go-review.googlesource.com/c/debug/+/618975\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "cba42236e06032c2f4ff8cb1180f8937845d5d46", "tree": "6a158d867a28ff9c9b511518e51e21c923c873b6", "parents": [ "2917a7a51c5028dbea1cdc1733435a460182e372" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Oct 04 14:24:53 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Oct 04 14:58:18 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I8187c05b50fa162da569082c251944737f7d1d3d\nReviewed-on: https://go-review.googlesource.com/c/debug/+/617957\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "2917a7a51c5028dbea1cdc1733435a460182e372", "tree": "e54a1d3d00116727ff92ed243565b3104ad2ca0d", "parents": [ "fbc6857c8a4f6bf3c0171d0ef4f02bafaa612667" ], "author": { "name": "Wang Deyu", "email": "wangdeyu.2021@bytedance.com", "time": "Fri Jun 21 22:10:38 2024 +0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Sep 10 21:51:04 2024 +0000" }, "message": "internal/gocore: use AttrGoKind to fix named slice type\n\nUse AttrGoKind instead of the name matching to check the slice and string type.\n\nFor golang/go#57447.\n\nChange-Id: I8765aa1a6315609b3476b8b84c27130629847235\nReviewed-on: https://go-review.googlesource.com/c/debug/+/593680\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Tim King \u003ctaking@google.com\u003e\nAuto-Submit: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\n" }, { "commit": "fbc6857c8a4f6bf3c0171d0ef4f02bafaa612667", "tree": "10dc70d80b86f9dd47a5cea42e9718f9f83e7295", "parents": [ "2392e042a5ccd915a4529ff1c0d3f7da21c1dd96" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Mon Aug 26 19:45:14 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Sep 05 15:36:19 2024 +0000" }, "message": "internal/gocore: support Go 1.22 allocation headers\n\nThis change supports Go 1.22 allocation headers by identifying all the\nheap pointers when enumerating spans. When looking over each span, we\ncheck to see where the pointer data for each value lives, and then\nenumerate all the pointers as needed.\n\nThis gets the goroot test passing again, which is a low bar... but it\u0027s\nsomething.\n\nWhile we\u0027re here, let\u0027s also get rid of a branch that only applied to an\nunreleased version of Go 1.22.\n\nFixes #63359.\n\nChange-Id: Id936a0e3b44d0fb0ec300fe957ac8218212de939\nReviewed-on: https://go-review.googlesource.com/c/debug/+/608475\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\n" }, { "commit": "2392e042a5ccd915a4529ff1c0d3f7da21c1dd96", "tree": "7de67866899501024b6bd3b979793b332709ada9", "parents": [ "93976b936a347f8e747a3231c4ab6421f0e03787" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Sep 04 14:10:42 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Sep 04 14:38:11 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I6a148a7ef4ef7c3f1005e55e4dcc8842bc5814c1\nReviewed-on: https://go-review.googlesource.com/c/debug/+/610636\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "93976b936a347f8e747a3231c4ab6421f0e03787", "tree": "57c9862097ec1096de05b3ade2dae1cba216ca43", "parents": [ "bf2ec109e29dba68b921009830f6590da0bb9377" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sun Aug 04 15:01:47 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Aug 06 15:15:15 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I923e9d019e49c252b4ca340d44ab75e07fe13f6b\nReviewed-on: https://go-review.googlesource.com/c/debug/+/602517\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "bf2ec109e29dba68b921009830f6590da0bb9377", "tree": "aae3a6804e9bf2f3b32d6ca69ad3088c31b3f3e0", "parents": [ "91dd60427047906fe9ca1b8eaf141032b2d276c3" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Jul 16 11:35:18 2024 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Jul 16 16:08:56 2024 +0000" }, "message": "LICENSE: update per Google Legal\n\nVery minor tweaks:\n - Remove (c) pseudosymbol.\n - Remove \"All Rights Reserved.\"\n - Change \"Google Inc.\" (no longer exists) to \"Google LLC\".\n\n[git-generate]\necho \u0027\n,s/\\(c\\) //\n,s/ All rights reserved.//\n,s/Google Inc./Google LLC/\nw\nq\n\u0027 | sam -d LICENSE\n\nChange-Id: Ifdc45b7ad642d6a5ccefae4f586baa71fb94b8c1\nReviewed-on: https://go-review.googlesource.com/c/debug/+/598576\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "91dd60427047906fe9ca1b8eaf141032b2d276c3", "tree": "24e4ac7d3bf878cbb9c19e1ac714eeeefd972fa2", "parents": [ "c35ceaf774d404cbf7d2e0d51c99b6147ebd0ab2" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jul 04 15:01:44 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jul 04 19:05:16 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I7187cfcb4a695c49de6918c715b6f0642e420141\nReviewed-on: https://go-review.googlesource.com/c/debug/+/596756\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Than McIntosh \u003cthanm@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "c35ceaf774d404cbf7d2e0d51c99b6147ebd0ab2", "tree": "5f860fc2c5984a42f0f00e0ab62405ed614743a9", "parents": [ "6a082a1aceafa88314c7c2730487c1d3de2858d2" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Jun 04 15:04:42 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Jun 04 16:56:01 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I417637e09b09b4686ffbb79d293e80706c7bd730\nReviewed-on: https://go-review.googlesource.com/c/debug/+/590235\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "6a082a1aceafa88314c7c2730487c1d3de2858d2", "tree": "0d906839f7b86d53db9b55b87a9b6dcb06b5d1f1", "parents": [ "0a45c2049523adaf186e1cf92d1f024a0799584a" ], "author": { "name": "Wang Deyu", "email": "wangdeyu.2021@bytedance.com", "time": "Mon Apr 29 14:51:18 2024 +0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Jun 04 16:55:58 2024 +0000" }, "message": "internal/gocore: fix funcdata offset\n\nCL 354011 remove unnecessary funcdata alignment. Update references.\n\nFor golang/go#57447.\n\nChange-Id: I14414ea4be048c3bb8bbde711c10474f7f0515e4\nReviewed-on: https://go-review.googlesource.com/c/debug/+/589035\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\n" }, { "commit": "0a45c2049523adaf186e1cf92d1f024a0799584a", "tree": "daaf0c4a7d80ea6e6c9b31199b014292af3c18ed", "parents": [ "d315aded89d9c5128c64ecc7a28ab29efa02b16b" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat May 04 15:02:12 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sun May 05 12:59:11 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I4295bc3ac05cbbdafe0838787a16c80bc68ebe0a\nReviewed-on: https://go-review.googlesource.com/c/debug/+/583276\nReviewed-by: Than McIntosh \u003cthanm@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "d315aded89d9c5128c64ecc7a28ab29efa02b16b", "tree": "648bfa7bb6e489bef2a6af9273972700849c7001", "parents": [ "598fefaade0fde7218b472be2473591c974ee74a" ], "author": { "name": "racequite", "email": "quiterace@gmail.com", "time": "Fri Apr 19 06:32:49 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Apr 19 15:27:11 2024 +0000" }, "message": "internal/gocore: fix some typos in comments\n\nChange-Id: I62aa60953035e5ee68e7c0b87b44579b2b23228b\nGitHub-Last-Rev: 03db157c7b6d50c3e7ca0cdae9958c48e971b3c0\nGitHub-Pull-Request: golang/debug#20\nReviewed-on: https://go-review.googlesource.com/c/debug/+/580295\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nAuto-Submit: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\n" }, { "commit": "598fefaade0fde7218b472be2473591c974ee74a", "tree": "cc06f3aa1452e3d8b4f6b757e8eaa7682c89890c", "parents": [ "01f1ac0ddf4325e7c2960a7c9f2f7f588f085744" ], "author": { "name": "cuishuang", "email": "imcusg@gmail.com", "time": "Tue Apr 16 17:46:34 2024 +0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Apr 16 16:00:50 2024 +0000" }, "message": "internal: fix function names in comment\n\nChange-Id: I2756372ad39888d6f3e6c06ae16fa4938bf4f43d\nReviewed-on: https://go-review.googlesource.com/c/debug/+/579195\nReviewed-by: qiu laidongfeng2 \u003c2645477756@qq.com\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\n" }, { "commit": "01f1ac0ddf4325e7c2960a7c9f2f7f588f085744", "tree": "f43abe5965adc77dd8b13f156f76aa69a6661165", "parents": [ "369212e2451fe9c7fe9c9b031f7052bfd57f4b2e" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Apr 04 15:09:53 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Apr 04 15:43:10 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Ib6bb3793f9bfc34db65c8ffeac30274998883762\nReviewed-on: https://go-review.googlesource.com/c/debug/+/576476\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Than McIntosh \u003cthanm@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "369212e2451fe9c7fe9c9b031f7052bfd57f4b2e", "tree": "714d5b7a040575ec1c90c9c084424c3e9f610d06", "parents": [ "513af1aa53249463097c73e73103ec1153517274" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Mar 04 15:02:01 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Mar 04 17:33:27 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I45df4f6fb03e90e5ba74d97e35eae79009737039\nReviewed-on: https://go-review.googlesource.com/c/debug/+/568777\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nReviewed-by: Than McIntosh \u003cthanm@google.com\u003e\n" }, { "commit": "513af1aa53249463097c73e73103ec1153517274", "tree": "5ae7244802606a0e979aa7818ced5485431e36f9", "parents": [ "6ef5bc2642e57aae2963dfc0a05d28b9cf3bab28" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Feb 07 16:24:02 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Feb 07 18:19:27 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Ie920391e4720bbf2949de75af48e32617c9e2223\nReviewed-on: https://go-review.googlesource.com/c/debug/+/562415\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Than McIntosh \u003cthanm@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "6ef5bc2642e57aae2963dfc0a05d28b9cf3bab28", "tree": "e0d7ea7203d11427296b74c59136424dd2195168", "parents": [ "f175d0adc34362bd85065c5e8abe95821b28a22b" ], "author": { "name": "Wang Deyu", "email": "wangdeyu.2021@bytedance.com", "time": "Wed Dec 06 11:55:45 2023 +0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jan 11 21:07:32 2024 +0000" }, "message": "internal/gocore: handle unsafe.pointer case for hchan.buf in chan\n\nIn the hchan struct, buf field is an unsefa.Pointer, and its actual type is\nan array of length hchan.dataqsiz and type hchan.elemtype.\nCorrect its type so that the object it points to can continue to be analyzed.\n\nFor golang/go#57447.\n\nChange-Id: I47969a9a8e2870bb9573587bac5416fbea9db9ac\nReviewed-on: https://go-review.googlesource.com/c/debug/+/547536\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Keith Randall \u003ckhr@golang.org\u003e\nReviewed-by: Keith Randall \u003ckhr@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "f175d0adc34362bd85065c5e8abe95821b28a22b", "tree": "00e2825cd4f662c628e98da8730e72d2b2b1bd95", "parents": [ "f50b87cbd4396c157afed4a0184133b8774ceb34" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jan 04 15:01:56 2024 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jan 04 15:06:06 2024 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I35982107ed6ccb23f14139ef8df3fce46a17cf5c\nReviewed-on: https://go-review.googlesource.com/c/debug/+/553995\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Than McIntosh \u003cthanm@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "f50b87cbd4396c157afed4a0184133b8774ceb34", "tree": "3f9adfd031ba3e95417107962d16d8b70642d680", "parents": [ "a36bd794d7b2ca88e89a47a9a74197a2fc86d00a" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Nov 27 15:33:47 2023 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Nov 27 15:36:49 2023 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I3b5dd88b4339397bc15be43dcce9a2c5bf97f15e\nReviewed-on: https://go-review.googlesource.com/c/debug/+/545115\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "a36bd794d7b2ca88e89a47a9a74197a2fc86d00a", "tree": "a1646cbe4c26fe0ad7116e465802ec49d8e2c9e0", "parents": [ "ae9888a91bcf8afb65d7e9ffe434afbb6e570b86" ], "author": { "name": "Michael Pratt", "email": "mpratt@google.com", "time": "Fri Nov 10 13:15:19 2023 -0500" }, "committer": { "name": "Michael Pratt", "email": "mpratt@google.com", "time": "Fri Nov 10 18:40:27 2023 +0000" }, "message": "internal/gocore: refactor heapArena reading\n\nThere are a lot of different historical changes to the heap arena\nstructure, making Process.readHeap difficult to follow. Refactor to\nsplit out version-specific logic to individual methods.\n\nReading allocation headers is not yet supported by this CL.\n\nFor golang/go#64049.\n\nChange-Id: Ia4198bd8492d8426c7a2cc8671b78c49ab6b7161\nReviewed-on: https://go-review.googlesource.com/c/debug/+/541131\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "ae9888a91bcf8afb65d7e9ffe434afbb6e570b86", "tree": "7e718744cdde0f7809d3a89f90b2c9614affd880", "parents": [ "d5d7f7b8f75b983e8a1adf65c0608b1b4286deac" ], "author": { "name": "Michael Anthony Knyszek", "email": "mknyszek@google.com", "time": "Fri Nov 10 15:33:19 2023 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Nov 10 16:30:13 2023 +0000" }, "message": "internal/gocore: skip the generated test to unblock the builder\n\nThis test is broken because the Go runtime at tip manages the\npointer/scalar metadata differently. Skip the test for now to unblock\nthe builder; I\u0027ll come back before the release to fix this.\n\nFor #64049.\n\nChange-Id: I1ac392e5c9e139b35896cd488bb5246c8c0a2478\nReviewed-on: https://go-review.googlesource.com/c/debug/+/541130\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nAuto-Submit: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "d5d7f7b8f75b983e8a1adf65c0608b1b4286deac", "tree": "baeb18d3de339ff7d7f82174a9b00550b02a0af9", "parents": [ "d6d0e89e1f4353f48d8b8de31b745b3fa26ee69e" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Nov 07 19:01:51 2023 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Nov 07 19:05:16 2023 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I58a171836d552e366d167509b821ca29e79a452f\nReviewed-on: https://go-review.googlesource.com/c/debug/+/540595\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "d6d0e89e1f4353f48d8b8de31b745b3fa26ee69e", "tree": "d9ac5e848cdfed155591ffdc43d10af74f3c9ca1", "parents": [ "7e676ac840af391ca7065d03ecabcf935f5b3d9d" ], "author": { "name": "Michael Pratt", "email": "mpratt@google.com", "time": "Tue Nov 07 10:39:37 2023 -0500" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Nov 07 15:46:15 2023 +0000" }, "message": "internal/gocore: update for CL 537978\n\nCL 537978 moved some fields in heapArena to a new struct. Update\nreferences.\n\nFixes golang/go#63359.\n\nChange-Id: I01bdbd6673249ac039bfd8e1890f19eab35e164f\nReviewed-on: https://go-review.googlesource.com/c/debug/+/540297\nAuto-Submit: Michael Pratt \u003cmpratt@google.com\u003e\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "7e676ac840af391ca7065d03ecabcf935f5b3d9d", "tree": "4085a1015dfbdf0ddcae0fe8f3439fa3d55a64b0", "parents": [ "17d98cbb1b3ccc9d31607e1efb81d3abec82009e" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Mon Oct 09 00:07:52 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Oct 09 18:58:59 2023 +0000" }, "message": "all: update go directive to 1.18\n\nDone with:\n\ngo get go@1.18\ngo mod tidy\ngo fix ./...\n\nUsing go1.21.2.\n\nChange-Id: Iab993489d7393a961c136a6f63279ca6bb7defce\nReviewed-on: https://go-review.googlesource.com/c/debug/+/533697\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "17d98cbb1b3ccc9d31607e1efb81d3abec82009e", "tree": "99b4e8528a46995f12d54a2e276527fdfa093dca", "parents": [ "b12aaab3ce7bdacceb5024cb8448f603d8a9d7d5" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Mon Oct 09 00:06:39 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Oct 09 18:58:56 2023 +0000" }, "message": "cmd/viewcore: don\u0027t try to build for GOARCH\u003dwasm\n\nIt doesn\u0027t build for GOOS\u003djs GOARCH\u003dwasm the same reason it doesn\u0027t\nbuild for aix and plan9: the readline dependency doesn\u0027t support it.\n\nFor golang/go#61104.\n\nChange-Id: Ic7f45fda06c2b01555048e2e167ae0e188b2b492\nCq-Include-Trybots: luci.golang.try:x_debug-gotip-js-wasm\nReviewed-on: https://go-review.googlesource.com/c/debug/+/533696\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "b12aaab3ce7bdacceb5024cb8448f603d8a9d7d5", "tree": "93ceb632844ad0ab54181c2d04f360fce4f29b5a", "parents": [ "aa2ab6ee3c24d4d4db2984c7b2f94f51b2fb28b1" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Oct 05 12:14:59 2023 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Oct 05 14:07:07 2023 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Iccb8d7665457d272f5065768dadc5ca5ddd606ce\nReviewed-on: https://go-review.googlesource.com/c/debug/+/532955\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "aa2ab6ee3c24d4d4db2984c7b2f94f51b2fb28b1", "tree": "12677f039ca770cf146903e130ffd904e8cc2afa", "parents": [ "184474b3e823dae7dd5d6a80d28c0405dbaf5ec1" ], "author": { "name": "Michael Pratt", "email": "mpratt@google.com", "time": "Wed Oct 04 15:50:03 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 04 19:55:44 2023 +0000" }, "message": "internal/gocore: update for CL 451359\n\nCL 451359 changed the size of mspan.nelems and mspan.freeindex. Update\nfor the new sizes.\n\nFixes golang/go#63359.\n\nChange-Id: I3ffc0843f0238cf27ddc047f6c4ed8781862d5ad\nReviewed-on: https://go-review.googlesource.com/c/debug/+/532735\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Michael Pratt \u003cmpratt@google.com\u003e\n" }, { "commit": "184474b3e823dae7dd5d6a80d28c0405dbaf5ec1", "tree": "f84d92be9599bdb3e053617042c2580504281cbc", "parents": [ "904067f65c6ee0231eb3b60c375b148f84187a90" ], "author": { "name": "Than McIntosh", "email": "thanm@google.com", "time": "Mon Sep 11 13:05:16 2023 -0400" }, "committer": { "name": "Than McIntosh", "email": "thanm@google.com", "time": "Tue Sep 12 17:01:26 2023 +0000" }, "message": "dwtest: add explicit testpoint for runtime.throw\n\nAdd a new testpoint that verifies the DWARF var location for the\nincoming parameter of the function \u0027runtime.throw\u0027. We already have\ntestpoings that validate DWARF for regular user-written functions that\ntake a single string argument (as does \u0027runtime.throw\u0027), but it is\ngood to test the function in the runtime as well, since the rules for\ncompiling the runtime are special, and we occasionally problems with\nDWARF generation can crop up that are runtime-specific.\n\nFixes golang/go#62523.\n\nCq-Include-Trybots: luci.golang.try:x_debug-gotip-linux-amd64-longtest\nChange-Id: I6558d9f12b22c997535cfc23d4b0758b10bd9548\nReviewed-on: https://go-review.googlesource.com/c/debug/+/526836\nReviewed-by: Alessandro Arzilli \u003calessandro.arzilli@gmail.com\u003e\nReviewed-by: Hyang-Ah Hana Kim \u003chyangah@gmail.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "904067f65c6ee0231eb3b60c375b148f84187a90", "tree": "32893c8289efe0bf1ab030874587a98fa08e7cb1", "parents": [ "180a5d4e6e1521d466cad739007e9f00480188e3" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat Sep 02 12:16:18 2023 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sun Sep 03 13:07:17 2023 +0000" }, "message": "go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: If36da6f5a39eb1bc685b841a9647b10278cf109d\nReviewed-on: https://go-review.googlesource.com/c/debug/+/525277\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nRun-TryBot: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "180a5d4e6e1521d466cad739007e9f00480188e3", "tree": "1bb37b02cd688ded28fc567e37bf2ff986ef9f8f", "parents": [ "17953bea613c7852121bb3dc1cbb6579eceaece9" ], "author": { "name": "Michael Pratt", "email": "mpratt@google.com", "time": "Tue Jun 27 11:07:48 2023 -0400" }, "committer": { "name": "Michael Pratt", "email": "mpratt@google.com", "time": "Fri Jun 30 18:45:26 2023 +0000" }, "message": "internal/core: refactor loading for maintainability\n\nLoading a new core.Process in core.Core is a rather long, complex\nprocess. Currently, this function creates a stub Process with very few\nfields set, and then subsequent method calls initially the remaining\nfields.\n\nThe problem with this approach is that the inputs/requirements and\noutputs of these initialization methods is poorly documented. These\nmethods (e.g., readCore) usually have some prerequisite fields in Process\nthat must be set on entry, and some fields that they set prior to\nreturn.\n\nNeither of these are well documented, and many are far from obvious. For\nexample, Process.mainExecName is initialized in readCore -\u003e readNote -\u003e\nreadNTFile -\u003e openMappedFile.\n\nThis is made more of a mess by the fact that Process tries to do most\ninitialization with a single pass, resulting in fields getting\ninitialized in unintuitive locations (such as mainExecName).\n\nThese combine to make refactoring to support new functionality\ndifficult, as changing ordering breaks implicit dependencies between\nmethods.\n\nThis CL addresses these issues by eliminating the iterative\ninitialization of Process. Instead, Process is only instantiated once\nall fields are ready. During loading, all work is done by free\nfunctions/types, where inputs and outputs are explicit via function\narguments/returns.\n\nThis may inadvertently improve golang/go#44757, as it makes main binary\nlookup more explicit.\n\nThis CL intends to keep behavior the same, but there are a few changes:\n\n* If the entry point is unknown, We no longer apply the heuristic of\n assuming that first executable mapping is the main binary. This could\n be added back, but it is probably better to ensure that the entry\n point is available on all architectures.\n\n* Failure to ELF parse a file for symbols isn\u0027t a hard error (as the\n mapped file might not even be an ELF).\n\nFor golang/go#57447.\n\nChange-Id: I7c3712ccb99ceddddc6adbae57d477c25ff4e5ba\nReviewed-on: https://go-review.googlesource.com/c/debug/+/506558\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nRun-TryBot: Michael Pratt \u003cmpratt@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "17953bea613c7852121bb3dc1cbb6579eceaece9", "tree": "04bda1028b424eb44e763645d3e8488f8a44c70f", "parents": [ "f77cf46cdfd593600f76f529faf952c81bb6e8df" ], "author": { "name": "Than McIntosh", "email": "thanm@google.com", "time": "Tue Jun 20 10:38:50 2023 -0400" }, "committer": { "name": "Than McIntosh", "email": "thanm@google.com", "time": "Wed Jun 21 15:22:44 2023 +0000" }, "message": "dwtest: add a flag to preserve tmp files following a test run\n\nAdd a \"-keep\" flag to the test that preserves the top level temp dir\nto allow developers to inspect intermediate executables, etc. Helpful\nfor debugging test failures.\n\nChange-Id: Ie0e729fde45e953536203b4a008aeceef7333006\nReviewed-on: https://go-review.googlesource.com/c/debug/+/504835\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nRun-TryBot: Than McIntosh \u003cthanm@google.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "f77cf46cdfd593600f76f529faf952c81bb6e8df", "tree": "258214e2862f688b51bbf398824f6b0753c91627", "parents": [ "36716089901d6bd6afeaa2677562ce1491eb20c1" ], "author": { "name": "Than McIntosh", "email": "thanm@google.com", "time": "Wed Jun 21 10:31:39 2023 -0400" }, "committer": { "name": "Than McIntosh", "email": "thanm@google.com", "time": "Wed Jun 21 15:20:56 2023 +0000" }, "message": "dwtest: update go.mod for delve-based test harness\n\nThe test harness for the variable location tests in \"dwtest\"\nwas using an out-of-date version of Delve; update to something\nmore recent.\n\nUpdates golang/go#60493.\n\nChange-Id: I4e72fd12fa1c6e07094067402b2c8693e37eea39\nReviewed-on: https://go-review.googlesource.com/c/debug/+/504836\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nRun-TryBot: Than McIntosh \u003cthanm@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "36716089901d6bd6afeaa2677562ce1491eb20c1", "tree": "b8ff94630bc358339f27b7c8a124f96bb5971745", "parents": [ "00090926acce20e904c1623aa22bd3346c59ac84" ], "author": { "name": "Meng Zhuo", "email": "mzh@golangcn.org", "time": "Sun Oct 30 21:09:54 2022 +0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Nov 02 18:10:09 2022 +0000" }, "message": "all: update sys to 0.1.0\n\nThis CL update golang.org/x/sys to 0.1.0 for\nFreeBSD/riscv64 porting\n\nFor golang/go#53466\n\nChange-Id: I56c920d17c0d6a08cf89c927fa840c55a59d6e83\nReviewed-on: https://go-review.googlesource.com/c/debug/+/446515\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\nRun-TryBot: Meng Zhuo \u003cmzh@golangcn.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nRun-TryBot: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Bryan Mills \u003cbcmills@google.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\n" }, { "commit": "00090926acce20e904c1623aa22bd3346c59ac84", "tree": "680c3d1ba42650d054ab2dc576f906b3c10c1e3b", "parents": [ "89a1939e1c09f35a21ada2ef0c5c64c55e4ab772" ], "author": { "name": "cui fliter", "email": "imcusg@gmail.com", "time": "Mon Sep 19 09:22:15 2022 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Sep 20 02:27:33 2022 +0000" }, "message": "internal: use constant to avoid repeated definitions\n\nChange-Id: I7cf3114a66ac57b3c93ba04dfff6cf4adc7c93b2\nGitHub-Last-Rev: eb1da5a48a44189ae1c8aa8245fe3616c9c51eaf\nGitHub-Pull-Request: golang/debug#17\nReviewed-on: https://go-review.googlesource.com/c/debug/+/431557\nRun-TryBot: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nRun-TryBot: Ian Lance Taylor \u003ciant@golang.org\u003e\n" }, { "commit": "89a1939e1c09f35a21ada2ef0c5c64c55e4ab772", "tree": "0d259192056a45bcb50be2c295878f1df0ec15dd", "parents": [ "f87892dd795c4676656be5c41a5787db8ff17252" ], "author": { "name": "cui fliter", "email": "imcusg@gmail.com", "time": "Fri Sep 16 02:10:17 2022 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Sep 19 16:54:56 2022 +0000" }, "message": "all: replace io/ioutil with io and os package\n\nFor golang/go#45557\n\nChange-Id: Ia95cb5fca120899b6643639dabe8e8ae99eaf193\nGitHub-Last-Rev: 529b29f971f53560b71650dbc92ed33ef94a8c18\nGitHub-Pull-Request: golang/debug#16\nReviewed-on: https://go-review.googlesource.com/c/debug/+/430857\nRun-TryBot: Ian Lance Taylor \u003ciant@google.com\u003e\nRun-TryBot: Ian Lance Taylor \u003ciant@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Meng Zhuo \u003cmzh@golangcn.org\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nRun-TryBot: Meng Zhuo \u003cmzh@golangcn.org\u003e\n" } ], "next": "f87892dd795c4676656be5c41a5787db8ff17252" }