tree bc32403079979b7bfd5b8771ec5a7fd3bf51dc64
parent a1f165e1349eb0f5fc9b0c99b44c5a7c2ab93e91
author Nicolas Hillegeer <aktau@google.com> 1728379026 -0700
committer Gopher Robot <gobot@golang.org> 1728489150 +0000

internal/gocore: add sanity checking to TestVersions

This strengthens the guarantees about what viewcore(1) supports.
Specifically, we have binaries built with PIE which appear to load
properly (`Core(...)` doesn't return an error, but return (e.g.) zero
goroutines. Tests should fail if this happens, there's always at least
one goroutine.

The sanity checking functions are defined separately so we can re-use
them in a test extension patch where we supply several types of binaries
built with non-standard flags (and without the `go build` tool).

Change-Id: I492724a7a9d371ce694829368c7dfb73066bb821
Reviewed-on: https://go-review.googlesource.com/c/debug/+/618976
Reviewed-by: Nicolas Hillegeer <aktau@google.com>
Auto-Submit: Nicolas Hillegeer <aktau@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Nicolas Hillegeer <aktau@google.com>