tree c766c1f8b8ccad3cad874b642fb28685a5d2bdb1
parent 547453c34fb121ed0dae9624edc8a7a0c1e4e87d
author Hana Kim <hyangah@gmail.com> 1537898160 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1539750653 +0000

internal/core: change how to determine the main binary

Previously, viewcore assumed that the first executable ELF
binary is the main binary and tried to get symbols and DWARF
out of it. We found the assumption can be wrong for the binary
compiled with pie or has mix of other languages.

Here we change the heuristic to determine the main binary:
the first executable mappings found from the note section.
This is consistent with the assumption we used to determine
when to utilize the --exe flag value while processing NT_FILE
records.

Also, this CL eliminates the file not found error type but utilizes
os.IsNotExist.

Change-Id: I0a41ffa7c81808d278a27f3d55a1fba204e39508
Reviewed-on: https://go-review.googlesource.com/c/137375
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>