tree 4ec4f245ca01dcf7b0c0fcd83363da7261886308
parent 31469a2049ca68f6ce80281568c2d81dc700f104
author Han-Wen Nienhuys <hanwen@google.com> 1516650319 +0100
committer Han-Wen Nienhuys <hanwen@google.com> 1516657027 +0000

ssh: use io.ReadFull() for reading chacha20-poly1305 packets.

Incomplete reads leave (part of) the verification tag zeroed, leading
to a failing MAC, and this is more likely to happen with larger
packets. The test added in the previous commit should stop this from
regressing.

Reinstate chacha20-poly1305 as a default cipher and prefer it over AES
CTR flavors.

Fixes golang/go#23510

Change-Id: I7599897e59448edb7b814eebcc8226ea15b365d6
Reviewed-on: https://go-review.googlesource.com/89075
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>