commit 21d60a152191de71c82a8101779e876bb03773b7
author cui fliter <imcusg@gmail.com> Wed Sep 07 12:51:24 2022 +0000
committer Keith Randall <khr@golang.org> Wed Nov 09 16:50:04 2022 +0000
tree c8e64c96f35d8f776dc44eedd115d018dbb6dec7
parent 183a9b70cc805eca27c9474ce65820b468a28795

all: remove redundant type conversion

Change-Id: Ic6b210c1e5b99eef5c6e38d96feaf40e7e6033bb
GitHub-Last-Rev: b8ecf761efe6a2eec78a805a99d778bdcdb938f9
GitHub-Pull-Request: golang/crypto#229
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/429016
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>

bcrypt/bcrypt.go

diff --git a/bcrypt/bcrypt.go b/bcrypt/bcrypt.go
index aeb73f8..addf56b 100644
--- a/bcrypt/bcrypt.go
+++ b/bcrypt/bcrypt.go
@@ -50,7 +50,7 @@
 type InvalidCostError int
 
 func (ic InvalidCostError) Error() string {
-	return fmt.Sprintf("crypto/bcrypt: cost %d is outside allowed range (%d,%d)", int(ic), int(MinCost), int(MaxCost))
+	return fmt.Sprintf("crypto/bcrypt: cost %d is outside allowed range (%d,%d)", int(ic), MinCost, MaxCost)
 }
 
 const (

cryptobyte/asn1.go

diff --git a/cryptobyte/asn1.go b/cryptobyte/asn1.go
index 3a1674a..a64c1d7 100644
--- a/cryptobyte/asn1.go
+++ b/cryptobyte/asn1.go
@@ -532,7 +532,7 @@
 		return false
 	}
 
-	paddingBits := uint8(bytes[0])
+	paddingBits := bytes[0]
 	bytes = bytes[1:]
 	if paddingBits > 7 ||
 		len(bytes) == 0 && paddingBits != 0 ||
@@ -554,7 +554,7 @@
 		return false
 	}
 
-	paddingBits := uint8(bytes[0])
+	paddingBits := bytes[0]
 	if paddingBits != 0 {
 		return false
 	}

openpgp/armor/armor.go

diff --git a/openpgp/armor/armor.go b/openpgp/armor/armor.go
index be342ad..8907183 100644
--- a/openpgp/armor/armor.go
+++ b/openpgp/armor/armor.go
@@ -156,7 +156,7 @@
 	n, err = r.b64Reader.Read(p)
 	r.currentCRC = crc24(r.currentCRC, p[:n])
 
-	if err == io.EOF && r.lReader.crcSet && r.lReader.crc != uint32(r.currentCRC&crc24Mask) {
+	if err == io.EOF && r.lReader.crcSet && r.lReader.crc != r.currentCRC&crc24Mask {
 		return 0, ArmorCorrupt
 	}