)]}'
{
  "commit": "ebc8e463153182e44695bfc4e4ae8cfdc00aa86d",
  "tree": "fe78f8cdaf06749d0c05819a9c118a37ec309e4c",
  "parents": [
    "e944286e33103542b8b53277b95c38394976493f"
  ],
  "author": {
    "name": "Nicola Murino",
    "email": "nicola.murino@gmail.com",
    "time": "Sat Dec 09 14:25:29 2023 +0100"
  },
  "committer": {
    "name": "Gopher Robot",
    "email": "gobot@golang.org",
    "time": "Thu May 15 10:47:05 2025 -0700"
  },
  "message": "ssh: add server side support for Diffie Hellman Group Exchange\n\nWe add this support for the following reasons:\n\n- We are planning to expose recommended (secure) vs. supported (works,\n  not necessarily recommended) algorithms. The DHGEX kex is currently\n  only exposed as a client-side kex. To simplify the calling convention\n  for this follow-on, we expose the server side too.\n- Some clients are quite inflexible with reference to kex algorithms\n  choice, for example they offer:\n\n  diffie-hellman-group-exchange-sha256, diffie-hellman-group-exchange-sha1,\n  diffie-hellman-group14-sha1, diffie-hellman-group1-sha1\n\n  therefore DHGEX helps interoperability.\n\nWe do not recommend the DHGEX kex as a whole:\n\n- the negotiation requires an extra round trip\n- the server must generate parameters (slow) or hardcode them, which\n  defeats the security benefit over traditional DH.\n\nIn this implementation we hardcode sending Oakley Group 14, Oakley\nGroup 15 or Oakley Group 16 based on the requested max size.\n\nUsers that are concerned with security of classical DH kex should\nmigrate to kex based on EC or Ed25519.\n\nFixes golang/go#54743\n\nChange-Id: I127822e90efc36821af4aca679931f40a2023021\nReviewed-on: https://go-review.googlesource.com/c/crypto/+/532415\nReviewed-by: Michael Knyszek \u003cmknyszek@google.com\u003e\nAuto-Submit: Nicola Murino \u003cnicola.murino@gmail.com\u003e\nReviewed-by: Filippo Valsorda \u003cfilippo@golang.org\u003e\nReviewed-by: Han-Wen Nienhuys \u003chanwen@google.com\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b98b51c19c20db81f7c025ea41157a3214618625",
      "old_mode": 33188,
      "old_path": "ssh/common.go",
      "new_id": "0415d33968b579a4a82032e23d789c35b951a0a5",
      "new_mode": 33188,
      "new_path": "ssh/common.go"
    },
    {
      "type": "modify",
      "old_id": "184544a153db1ce19fd8cde25574809753d07f51",
      "old_mode": 33188,
      "old_path": "ssh/kex.go",
      "new_id": "cf388a92aa3a19f77d77ab76790bac75f16447e4",
      "new_mode": 33188,
      "new_path": "ssh/kex.go"
    },
    {
      "type": "modify",
      "old_id": "118427bc059088b9b2f7db300016e9917ad41a8c",
      "old_mode": 33188,
      "old_path": "ssh/messages.go",
      "new_id": "251b9d06a32425c15db4050986cb95987cf12e77",
      "new_mode": 33188,
      "new_path": "ssh/messages.go"
    },
    {
      "type": "modify",
      "old_id": "f912bfb8acc1a589f2b7f4e19d41a2a56c9faa9e",
      "old_mode": 33188,
      "old_path": "ssh/server.go",
      "new_id": "98679ba5b6ed2e1ca202e5196c425f0975183b9f",
      "new_mode": 33188,
      "new_path": "ssh/server.go"
    },
    {
      "type": "modify",
      "old_id": "ac2f7c10a94664b7bd0314fed43d7851aed2cbc0",
      "old_mode": 33188,
      "old_path": "ssh/test/sshcli_test.go",
      "new_id": "66480674590f59b23464f592e6da5455eef8e6ed",
      "new_mode": 33188,
      "new_path": "ssh/test/sshcli_test.go"
    }
  ]
}