tree 69fd475f65b8443c91119651a1c9b37a5fa05dad
parent 84ca184138ec653f724c2dd81d4e96bfe2b9b68a
author Adam Langley <agl@golang.org> 1400003513 -0700
committer Adam Langley <agl@golang.org> 1400003513 -0700
golang-hg 23b39e4e860172e1983ded00a9d2f7e42b7683d0

go.crypto/ssh: fix authentication after all public keys are rejected by a server.

Validating a public key doesn't return any remaining methods so, if all public keys were rejected, a nil slice would be returned for the remaining methods and authentication would stop.

We could have validateKey return methods, but that wouldn't solve the problem of what to do if the callback returns no keys. In that case we don't have any keys to test.

So this change makes it possible for an AuthMethod to return a nil slice for the remaining methods (meaning "reuse the last list"). It also fixes a scoping bug.

Fixes golang/go#7787.

LGTM=hanwen
R=hanwen
CC=golang-codereviews
https://golang.org/cl/94350043