cmd/watcher: correctly assemble query string when posting commits

Change-Id: I97b6e77103bfd0e7a6efae9d73cfa61a546ffc59
Reviewed-on: https://go-review.googlesource.com/10096
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

cmd/watcher/watcher.go

diff --git a/cmd/watcher/watcher.go b/cmd/watcher/watcher.go
index 287dc7c..b9951fd 100644
--- a/cmd/watcher/watcher.go
+++ b/cmd/watcher/watcher.go
@@ -336,21 +336,25 @@
 		return nil
 	}
 
-	u := fmt.Sprintf("%vcommit?version=%v&key=%v", *dashboard, watcherVersion, dashboardKey)
+	v := url.Values{"version": {fmt.Sprint(watcherVersion)}, "key": {dashboardKey}}
+	u := *dashboard + "commit?" + v.Encode()
 	resp, err := http.Post(u, "text/json", bytes.NewReader(b))
 	if err != nil {
 		return err
 	}
-	defer resp.Body.Close()
+	body, err := ioutil.ReadAll(resp.Body)
+	resp.Body.Close()
+	if err != nil {
+		return fmt.Errorf("postCommit: reading body: %v", err)
+	}
 	if resp.StatusCode != 200 {
-		return fmt.Errorf("postCommit: status: %v", resp.Status)
+		return fmt.Errorf("postCommit: status: %v\nbody: %s", resp.Status, body)
 	}
 
 	var s struct {
 		Error string
 	}
-	err = json.NewDecoder(resp.Body).Decode(&s)
-	if err != nil {
+	if err := json.Unmarshal(body, &s); err != nil {
 		return fmt.Errorf("postCommit: decoding response: %v", err)
 	}
 	if s.Error != "" {
@@ -775,7 +779,6 @@
 				last[repo] = hash
 				select {
 				case repoTickler(repo) <- true:
-					log.Printf("tickled the %s repo poller", repo)
 				default:
 				}
 			}