devapp/owners: make @golang/runtime owner of runtime packages
I am using a fairly loose definition of "runtime" here to cover most of
the packages the runtime team tends to support.
GitHub teams cannot be Gerrit reviewers, but as of CL 386754, gopherbot
will add any other primary owners as CL reviewers, and if there are no
other primary reviewers then secondary owners will be added as reviewers
(rather than CC).
This CL primarily moves former primary owners to secondary owners, thus
there are minimal changes to reviewer assignment.
Thus, the overall effective changes here are:
* Folks doing triage will default to CC'ing @golang/runtime on issues
rather than individuals.
* Numerous previously ownerless internal/ packages gain owners.
* Added additional owners to a few packages. No owners removed.
* Previously secondary owners of runtime (iant, dvyukov, martisch) will
now be added as reviewer on CLs instead of CC due to gopherbot
behavior mentioned above. If this is a problem we could alternatively
keep the existing primary owners on the primary line alongside
runtimeTeam.
* Similar secondary change for tklauser on syscall.
Change-Id: Ib4724cb6da81203ea5ba6536d0aa5b63f31ef385
Reviewed-on: https://go-review.googlesource.com/c/build/+/386796
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
diff --git a/devapp/owners/table.go b/devapp/owners/table.go
index 4b2afa0..dcbd061 100644
--- a/devapp/owners/table.go
+++ b/devapp/owners/table.go
@@ -87,6 +87,7 @@
fuzzingTeam = gh("golang/fuzzing")
pkgsiteTeam = gh("golang/pkgsite")
+ runtimeTeam = gh("golang/runtime")
toolsTeam = gh("golang/tools-team")
)
@@ -184,10 +185,12 @@
},
"go/src/cmd/link/internal/wasm": wasmOwners,
"go/src/cmd/pprof": {
- Primary: []Owner{cherryyz},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{cherryyz},
},
"go/src/cmd/trace": {
- Primary: []Owner{mknyszek, prattmic},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{mknyszek, prattmic},
},
"go/src/cmd/vet": {
Primary: []Owner{matloob},
@@ -343,18 +346,52 @@
"go/src/index/suffixarray": {
Primary: []Owner{gri},
},
+ "go/src/internal/abi": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{mknyszek, cherryyz},
+ },
"go/src/internal/bytealg": {
Primary: []Owner{khr},
Secondary: []Owner{josharian},
},
"go/src/internal/cpu": {
- Primary: []Owner{khr, martisch},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{khr, martisch},
},
"go/src/internal/fuzz": {
Primary: []Owner{katie, roland},
},
+ "go/src/internal/goarch": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{mknyszek, prattmic},
+ },
+ "go/src/internal/godebug": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{mknyszek, prattmic},
+ },
+ "go/src/internal/goexperiment": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{austin, mknyszek},
+ },
+ "go/src/internal/goos": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{mknyszek, prattmic},
+ },
+ "go/src/internal/poll": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{iant, prattmic},
+ },
"go/src/internal/profile": {
- Primary: []Owner{cherryyz},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{cherryyz, prattmic},
+ },
+ "go/src/internal/race": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{dvyukov, iant},
+ },
+ "go/src/internal/reflectlite": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{rsc, iant},
},
"go/src/internal/singleflight": {
Primary: []Owner{bradfitz, iant},
@@ -380,7 +417,8 @@
Secondary: []Owner{josharian},
},
"go/src/internal/trace": {
- Primary: []Owner{mknyszek, prattmic},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{mknyszek, prattmic},
},
"go/src/io": {
Primary: []Owner{gri},
@@ -453,7 +491,8 @@
Primary: []Owner{bradfitz, iant},
},
"go/src/os/signal": {
- Primary: []Owner{iant},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{iant, prattmic},
},
"go/src/os/user": {
Primary: []Owner{bradfitz},
@@ -466,11 +505,12 @@
Primary: []Owner{r, rsc},
},
"go/src/plugin": {
- Primary: []Owner{iant},
- Secondary: []Owner{cherryyz},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{iant, cherryyz},
},
"go/src/reflect": {
- Primary: []Owner{rsc, iant},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{rsc, iant},
},
"go/src/regexp": {
Primary: []Owner{rsc},
@@ -480,32 +520,40 @@
Primary: []Owner{rsc},
},
"go/src/runtime": {
- Primary: []Owner{austin, khr, mknyszek, prattmic},
- Secondary: []Owner{iant, dvyukov, martisch},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{austin, khr, mknyszek, prattmic, iant, dvyukov, martisch},
},
"go/src/runtime/cgo": {
- Primary: []Owner{iant},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{iant, cherryyz},
},
"go/src/runtime/internal/atomic": {
- Primary: []Owner{austin, khr},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{austin, khr, mknyszek},
},
"go/src/runtime/internal/sys": {
- Primary: []Owner{austin, khr},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{austin, khr},
},
"go/src/runtime/internal/syscall": {
- Primary: []Owner{prattmic, mknyszek, austin},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{prattmic, mknyszek, austin},
+ },
+ "go/src/runtime/metrics": {
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{mknyszek, prattmic},
},
"go/src/runtime/pprof": {
- Primary: []Owner{cherryyz, prattmic},
- },
- "go/src/runtime/pprof/internal/protopprof": {
- Primary: []Owner{cherryyz},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{cherryyz, prattmic},
},
"go/src/runtime/race": {
- Primary: []Owner{dvyukov},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{dvyukov, iant},
},
"go/src/runtime/trace": {
- Primary: []Owner{mknyszek, prattmic, dvyukov},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{mknyszek, prattmic, dvyukov},
},
"go/src/sort": {
Primary: []Owner{rsc, gri, iant, bradfitz},
@@ -518,14 +566,16 @@
Secondary: []Owner{iant, bradfitz},
},
"go/src/sync": {
- Primary: []Owner{rsc, iant, dvyukov, austin},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{rsc, iant, dvyukov, austin},
},
"go/src/sync/atomic": {
- Primary: []Owner{rsc, iant, dvyukov, austin},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{rsc, iant, dvyukov, austin},
},
"go/src/syscall": {
- Primary: []Owner{iant, bradfitz},
- Secondary: []Owner{tklauser},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{iant, bradfitz, tklauser},
},
"go/src/testing": {
Primary: []Owner{bcmills},
@@ -592,6 +642,7 @@
Secondary: []Owner{roland, filippo},
},
"debug": {
+ Primary: []Owner{runtimeTeam},
Secondary: []Owner{hyangah, khr},
},
"mobile": {
@@ -634,10 +685,12 @@
Primary: []Owner{bcmills},
},
"sys/unix": {
- Primary: []Owner{iant, bradfitz, tklauser},
+ Primary: []Owner{runtimeTeam},
+ Secondary: []Owner{iant, bradfitz, tklauser},
},
"sys/windows": {
- Primary: []Owner{alexbrainman, bradfitz},
+ Primary: []Owner{runtimeTeam, alexbrainman},
+ Secondary: []Owner{bradfitz},
},
"text": {
Primary: []Owner{mpvl},
diff --git a/internal/gophers/gophers.go b/internal/gophers/gophers.go
index 877b65f..fa3ae60 100644
--- a/internal/gophers/gophers.go
+++ b/internal/gophers/gophers.go
@@ -118,6 +118,7 @@
addPerson("Gerrit Bot", "letsusegerrit@gmail.com", "12446@62eb7196-b449-3ce5-99f1-c037f21e1705", "*bot")
addPerson("Fuzzing Team", "@golang/fuzzing")
addPerson("Pkgsite Team", "@golang/pkgsite")
+ addPerson("Runtime Team", "@golang/runtime")
addPerson("Tools Team", "@golang/tools-team")
addPerson("212472270", "ggp493@gmail.com", "@ggriffiths")
