commit df58bbac082bc87c4a3cdfe336d1ffe60bbaa916
author Matthew Dempsky <mdempsky@google.com> Wed Jun 16 23:08:22 2021 -0700
committer Matthew Dempsky <mdempsky@google.com> Thu Jun 17 17:42:13 2021 +0000
tree 82af94dfdb193fffb57856ed1f7f11524d5d32e4
parent 666c18fd0701c9908e2cf900e28ec493f16732e2

dashboard: add linux-amd64-unified builder

This adds a trybot+builder for testing cmd/compile's unified IR
construction experiment on the dev.typeparams branch.

Fixes golang/go#46786.

Change-Id: Ibf3d5ab7a727c52cf13486798e02077faa08e2b5
Reviewed-on: https://go-review.googlesource.com/c/build/+/328891
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>

dashboard/builders.go

diff --git a/dashboard/builders.go b/dashboard/builders.go
index 1bbcde0..2e0dd10 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -1745,6 +1745,26 @@
 		},
 	})
 	addBuilder(BuildConfig{
+		Name:     "linux-amd64-unified",
+		HostType: "host-linux-buster",
+		Notes:    "builder with GOEXPERIMENT=unified, see golang.org/issue/46786",
+		tryBot: func(repo, branch, goBranch string) bool {
+			return (repo == "go" || repo == "tools") && goBranch == "dev.typeparams"
+		},
+		buildsRepo: func(repo, branch, goBranch string) bool {
+			return (repo == "go" || repo == "tools") && goBranch == "dev.typeparams"
+		},
+		env: []string{
+			"GO_DISABLE_OUTBOUND_NETWORK=1",
+			"GOEXPERIMENT=unified",
+		},
+		GoDeps: []string{
+			"804ecc2581caf33ae347d6a1ce67436d1f74e93b", // CL 328215, which added GOEXPERIMENT=unified on dev.typeparams
+		},
+		numTestHelpers:    1,
+		numTryTestHelpers: 4,
+	})
+	addBuilder(BuildConfig{
 		Name:     "linux-amd64-noregabi",
 		HostType: "host-linux-buster",
 		Notes:    "builder with GOEXPERIMENT=noregabi, see golang.org/issue/40724",

dashboard/builders_test.go

diff --git a/dashboard/builders_test.go b/dashboard/builders_test.go
index 1cabe15..9666895 100644
--- a/dashboard/builders_test.go
+++ b/dashboard/builders_test.go
@@ -120,7 +120,7 @@
 		},
 		{
 			repo:   "go",
-			branch: "dev.link",
+			branch: "dev.typeparams",
 			want: []string{
 				"android-amd64-emu",
 				"freebsd-amd64-12_2",
@@ -128,6 +128,7 @@
 				"linux-386",
 				"linux-amd64",
 				"linux-amd64-race",
+				"linux-amd64-unified",
 				"linux-arm-aws",
 				"linux-arm64-aws",
 				"openbsd-amd64-68",
@@ -617,6 +618,13 @@
 		{b("linux-amd64-staticlockranking@go1.14", "go"), none},
 		{b("linux-amd64-staticlockranking", "net"), none},
 
+		{b("linux-amd64-unified", "go"), none},
+		{b("linux-amd64-unified", "tools"), none},
+		{b("linux-amd64-unified", "net"), none},
+		{b("linux-amd64-unified@dev.typeparams", "go"), both},
+		{b("linux-amd64-unified@dev.typeparams", "tools"), both},
+		{b("linux-amd64-unified@dev.typeparams", "net"), none},
+
 		{b("linux-amd64-noregabi", "go"), onlyPost},
 		{b("linux-amd64-noregabi", "net"), none},
 	}