tree 03d78106f8632eaf10b98b8b8161be42a7332a45
parent 7b90c2e750aabaa3611a6aebe63b1605b21070c3
author Dmitri Shuralyov <dmitshur@golang.org> 1568381295 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1568740754 +0000

cmd/coordinator: factor out GOPATH dep fetching from runSubrepoTests

The code to fetch golang.org/x/* dependencies has become deeply nested
after additional logic and complexity has been added to runSubrepoTests,
making it harder to read, maintain, and be confident in. Factor it out
into a dedicated and well documented method.

This CL is a pure refactor. The next CL will make changes to simplify
the dependency fetching logic, which becomes easer after it has been
factored out.

Also factor out the code to concatenate multiple errors from
runSubrepoTests into a helper multiError type, and simplify
path.Join("go", "bin", "go") to a constant "go/bin/go".

Fixes golang/go#34247

Change-Id: I4b5775408056723e2e5ab9a84776a11f5069d58a
Reviewed-on: https://go-review.googlesource.com/c/build/+/195277
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>