tree db98e9688d62d0bf4597f3cbf29dcace413ee690
parent c94fcd7e3ef9b0270f5e755503aac6d24e8f6f28
author Heschi Kreinick <heschi@google.com> 1622577391 -0400
committer Heschi Kreinick <heschi@google.com> 1622838228 +0000

cmd/gitmirror: refactor

In preparation for adding a new mirror destination, refactor. A lot of
this is subjective, and arguably just my personal taste. Still, I think
it's an improvement.

Generally, I don't intend to change behavior here. Two small things:
first, the list of repositories to watch is read from the repos package
rather than Gerrit; I don't think that matters, but please correct me if
I'm wrong. Second, we start a repo Loop for every repository, not just
those being mirrored. I think this was an oversight, and it resulted in
the repository not being eagerly fetched.

Notable refactorings:
- Remove the package vars: "tickler" channels move into Repo, others
  into the new top-level mirror type.
- Remove some overly fancy logging; I personally don't mind reading
  "attempt 0" in a message, etc.
- Restructure initialization logic to hopefully be a little bit better
  grouped and more readable.
- Introduce the concept of multiple destinations, but don't use it yet.
- Rather than checking for the correct remotes during initialization,
  just blow them away and recreate them.

Change-Id: I906f45fb93e2e4a2552aea5560eeb244174bfe69
Reviewed-on: https://go-review.googlesource.com/c/build/+/323970
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>