tree 96d19a3cd933566d2baa886a9f35e5a96bcc69fb
parent eb8c3e6a87d3efe06b07d2c5722fe6cba5718fad
author Dmitri Shuralyov <dmitshur@golang.org> 1643844756 -0500
committer Dmitri Shuralyov <dmitshur@golang.org> 1645041238 +0000

internal/task: accept secrets explicitly via ExternalConfig struct

Previously, the tweet tasks fetched Twitter API credentials implicitly
from the environment, and a dryRun bool parameter was used to disable
the task from actually posting a tweet (useful for running tests).

This doesn't scale well to being able to supply different credentials,
which is needed to be able to run the task in a staging environment,
using a staging/test set of credentials.

Create an ExternalConfig struct for providing secrets for external
services that tasks need to interact with, making this more explicit.

This will be used by relui in its upcoming "create tweet" workflows.

Update the MailDLCL task analogously to accept the new ExternalConfig
parameter, making it more testable and dry-run-capable in the process.

Also switch to using *workflow.TaskContext (pointer, not value),
since that's what the x/build/internal/workflow package expects.

For golang/go#47402.
Updates golang/go#47405.

Change-Id: I40f0144a57ca0031840fbd1303ab56ac3fefc6c6
Reviewed-on: https://go-review.googlesource.com/c/build/+/382935
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>