tree 729501a088bed6e86fd6c98e7c4a6ebb7584426c
parent 7b161c0e4e45f0efd61d7d10b2319d4391e4655b
author Dmitri Shuralyov <dmitshur@golang.org> 1569462281 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1569510379 +0000

cmd/tip: don't install cmd/tip from the internet

Set the working directory in the Dockerfile to be inside the
golang.org/x/build module before running go install on cmd/tip.
Otherwise, it just installs the latest cmd/tip from the internet
rather than the intended local version. (All other Dockerfiles
in x/build had this line, except cmd/tip.)

Remove duplicate and unneeded WORKDIR instruction from two other
Dockerfiles to improve consistency.

Fix a rare race condition setting p.err when os.MkdirAll fails.

Add a log message when a new server has been started successfully
and the side switches. This will make logs easier to read.

Fixes golang/go#34526
Updates golang/go#34192

Change-Id: Iab8124f5c872fb87844e8e2f9b31637ce395f11b
Reviewed-on: https://go-review.googlesource.com/c/build/+/197302
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>