dashboard, cmd/coordinator: move cross compilation config into dashboard package
The dashboard package has been gradually absorbing all configuration,
keeping cmd/coordinator only about mechanics. But we'd missed this
cross compilation bit in earlier cleanups.
Move it, and add some tests & docs while I'm at it.
Also, disable the linux-arm-nativemake builder by default. It's
redundant with linux-arm. They used to be more different when we
always cross compiled for linux-arm, but I guess that got disabled at
some point. At this poin it serves no purpose except as an opt-in
slowbot if the user really wants to run make.bash on scaleway.
Change-Id: Iac683ccf4d30214330480f9db39f131263b1bf8a
Reviewed-on: https://go-review.googlesource.com/c/build/+/202020
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
diff --git a/dashboard/builders_test.go b/dashboard/builders_test.go
index 26611a8..e7a7699 100644
--- a/dashboard/builders_test.go
+++ b/dashboard/builders_test.go
@@ -713,3 +713,16 @@
t.Errorf("Missing items from slowBotAliases:\n%s", add.String())
}
}
+
+func TestCrossCompileConfigs(t *testing.T) {
+ // Verify that Builders.CrossCompileConfig have valid host types.
+ for name, bc := range Builders {
+ cc := bc.CrossCompileConfig
+ if cc == nil {
+ continue
+ }
+ if _, ok := Hosts[cc.CompileHostType]; !ok {
+ t.Errorf("unknown host type %q for builder %q", cc.CompileHostType, name)
+ }
+ }
+}
