tree b332e82c6537c1df8a2b9abc0a310573fb2df9f2
parent 357a85b84ac9b84a21131cf1ca4a2285b3e52a70
author Brad Fitzpatrick <bradfitz@golang.org> 1548308481 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> 1549922910 +0000

cmd/buildlet: recreate accidentally deleted dirs lazily

The buildlet's /removeall handler previously restored any deletes of
important directories (the $WORKDIR, $GOCACHE, and $TMP) immediately
after the deletes, before the /removeall handler returned to the
client.

Unfortunately, some clients actually do want to delete $GOCACHE and
$TMP: in CL 159257 (submitted too early), cmd/release wants to delete
those before tarring/zipping up the rest of $WORKDIR to ship a
release.

This CL changes the remove handler to just remove stuff without fixing
mistakes. Instead, missing directories are created lazily later if
needed.

Also, minor debug logging change to cmd/release that I hadn't yet
uploaded to CL 159257 before it was submitted.

Fixes golang/go#29906

Change-Id: Ifb5d3c16e2d83e7ac9e7f8e353d1b7b866f7d338
Reviewed-on: https://go-review.googlesource.com/c/159320
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>