tree f6daadf1f408e51615576f77660186236789be84
parent 1264b91768ecfaff69b2263f212f6e1b20ab42b3
author Alex Rakoczy <alex@golang.org> 1655915317 -0400
committer Gopher Robot <gobot@golang.org> 1656011670 +0000

internal/relui: stop relying on approval task name

Add a column to track whether approval is required for a task. This
relieves us from having to rely on a magic task name for showing the
button in the UI.

Unfortunately, we still need to capture the task name at definition time
in order to query it later on. It may make sense to relay the task's
name inside the TaskContext.

Adds documentation and minor refactoring to Approve tasks.

Updates approval polling interval to 5 seconds.

Fixes golang/go#53295

Change-Id: I46953ed3166944726a34f3f62dc8c4622201922e
Reviewed-on: https://go-review.googlesource.com/c/build/+/413575
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Auto-Submit: Alex Rakoczy <alex@golang.org>