maintner/maintnerd, cmd/coordinator: use maintnerd to find TryBot work
Instead of polling Gerrit every 60 seconds, poll maintnerd every
second. This should improve TryBot-requested to TryBot-running latency
by 30 seconds on average.
(Ideally it'd long poll for changes and not even have ~500ms delay,
but this is an improvement.)
Also, in the process this does most of the work for golang/go#17626.
And this cleans up the repo head tracking complication in the coordinator
and just asks maintner for it instead.
Running benchmarks in the coordinator has been disabled since
2017-06-23 but this CL disables it further, removing some code it'd
need to work. But considering that benchmarking would need code
repairs to get working again anyway, I consider this acceptable in the
short term. I left TODO notes.
Updates golang/go#17626
Updates golang/go#19871
Change-Id: Idab43f65a9cca861bffb37748b036a5c9baee864
Reviewed-on: https://go-review.googlesource.com/51590
Reviewed-by: Andrew Bonventre <andybons@golang.org>
diff --git a/maintner/gerrit_test.go b/maintner/gerrit_test.go
index 6eb8218..c44dbaa 100644
--- a/maintner/gerrit_test.go
+++ b/maintner/gerrit_test.go
@@ -165,3 +165,36 @@
}
}
}
+
+func TestLineValue(t *testing.T) {
+ tests := []struct {
+ all, prefix, want string
+ }{
+ {
+ all: "foo: value ",
+ prefix: "foo:",
+ want: "value",
+ },
+ {
+ all: "foo: value\n",
+ prefix: "foo:",
+ want: "value",
+ },
+ {
+ all: "bar: other\nfoo: value\n",
+ prefix: "foo:",
+ want: "value",
+ },
+ {
+ all: "notfoo: other\nfoo: value\n",
+ prefix: "foo:",
+ want: "value",
+ },
+ }
+ for _, tt := range tests {
+ got := lineValue(tt.all, tt.prefix)
+ if got != tt.want {
+ t.Errorf("lineValue(%q, %q) = %q; want %q", tt.all, tt.prefix, got, tt.want)
+ }
+ }
+}
