tree 4952e7d3951426f77cf83992a6443e12109a3cb1
parent c78805dbabc8e1c76873d591ca6a5ac1ee6ac1e2
author Brad Fitzpatrick <bradfitz@golang.org> 1551980681 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> 1552086073 +0000

dashboard: unify post-submit & trybot policy in builders.go, not coordinator

This removes a bunch of TODOs about scattered policy and moves it all
into builders.go.

While here,

* add a bunch of tests
* unexport some things
* rename some things
* document some things
* adjust FreeBSD policy as function of branch (per Go 1.12 being
  last to support FreeBSD 10.x, and to unblock CL 165801)
* set GO_BUILDER_SET_GOPROXY=coordinator for reverse buildlets,
  which is necessary to remove the oauth2 & build special cases
  in the config
* change Elias Naur's mobile builder to how I think he wants it
  (he was fighting the old system)
* add $HOME on the Solaris smartos builder, which was missing &
  causing tests to fail lately
* make the (currently failing) longtest builder have GOPROXY set
* remove an allocation in version.ParseReleaseBranch

Fixes golang/go#9603
Updates golang/go#14594

Change-Id: I50a23ad7cdf478c95b14bee9b3931ba361baacfa
Reviewed-on: https://go-review.googlesource.com/c/build/+/166218
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>