tree 2ab612373ac1a03c16c49bc801fc1d21bcc2cec1
parent eaf3171fb0095f62a621cf6ccbaa5c361059af62
author Dmitri Shuralyov <dmitshur@golang.org> 1628267302 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1628519662 +0000

cmd/coordinator/internal/legacydash: set Content-Type in htmlView

In htmlView.ServeDashboard, we know very well that the content being
served is HTML. Set the Content-Type header explicitly to indicate
that, to avoid clients from having to do needless computationally-
expensive guessing. (This will help the next change, where we need
to know the Content-Type to be able to rewrite URLs in said HTML.)

Also improve and inline the logErr helper that was undocumented
and used in only 3 places. It's more readable to use http.Error.

For golang/go#34744.

Change-Id: I783d6559274bd2b9eeb7efcfe9464122cf4a9a68
Reviewed-on: https://go-review.googlesource.com/c/build/+/340431
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>