maintner, devapp: display proper owner names instead of Gerrit User NNN
This change deletes the OwnerName method on GerritCL, since Gerrit's
format for its NoteDB backing store changed to display "Gerrit User NNN"
instead of the proper display name in the meta commit.
Update golang/go#28663
Change-Id: Ifa64ca2b2694b17e888451582b9c63f3f37280a9
Reviewed-on: https://go-review.googlesource.com/c/148557
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
diff --git a/devapp/reviews.go b/devapp/reviews.go
index 965598e..c1b17d2 100644
--- a/devapp/reviews.go
+++ b/devapp/reviews.go
@@ -71,7 +71,7 @@
for _, p := range s.data.reviews.Projects {
var cs []*change
for _, c := range p.Changes {
- if c.OwnerName() == ownerFilter {
+ if o := c.Owner(); o != nil && o.Name() == ownerFilter {
cs = append(cs, c)
totalChanges++
}
@@ -115,6 +115,7 @@
proj := &project{GerritProject: p}
p.ForeachOpenCL(func(cl *maintner.GerritCL) error {
if cl.WorkInProgress() ||
+ cl.Owner() == nil ||
strings.Contains(cl.Commit.Msg, "DO NOT REVIEW") ||
strings.Contains(cl.Commit.Msg, "DO NOT SUBMIT") {
return nil
