| commit | 5d3521b01056f3f44dcdf77aaf5f5fb6a6e175bd | [log] [tgz] |
|---|---|---|
| author | thepudds <thepudds1460@gmail.com> | Tue Sep 26 10:20:28 2023 -0400 |
| committer | Gopher Robot <gobot@golang.org> | Wed Sep 27 02:35:40 2023 +0000 |
| tree | bdd7d976bf10c4e133394f67fd30150e04576049 | |
| parent | 795af093fb57a4068fbfb2812a1bb79900bd027a [diff] |
cmd/gerritbot: avoid changing the content of comment sync messages CL 525976 included an update of several messages to use go.dev/wiki shortlinks instead of the equivalent github.com/golang/go/wiki links, including to be more future-proof given the wiki content is likely to move in the near future. This included updating the URL used in the sync messages posted on the GitHub PR to notify a contributor of a new Gerrit comment. This in turn caused GerritBot to start re-posting what were effectively duplicate sync comments to various open GitHub PRs. This is because GerritBot's sync of Gerrit comments to the GitHub PR is nicely simple, and currently relies on historical sync messages on the PR exactly matching what the current incarnation of GerritBot would have posted for old Gerrit comments. If the sync message content changes, GerritBot thinks it has never posted about even old Gerrit comments because it cannot find an exact match on the PR, and hence posts the new sync message content about old Gerrit comments. This CL restores the content of the sync messages, and adds a comment to help future contributors. The other messages modified in CL 525976 were not affected in the same way because they are posted in reaction to an event of creating a new GitHub PR or an update to the PR. Those other messages have also recently been modified by other CLs without triggering reposts. CL 525976 was noticed as misbehaving within ~10 minutes of being deployed. Also within ~10 minutes of being deployed, GerritBot encountered a 403 error and stopped posting duplicates: 403 You have exceeded a secondary rate limit and have been temporarily blocked from content creation The deployment was rolled back ~10 minutes after that. Updates golang/go#61573 Change-Id: Ibc5d299494baaa26118916799eaed023e5ccb26c Reviewed-on: https://go-review.googlesource.com/c/build/+/530736 Reviewed-by: Heschi Kreinick <heschi@google.com> Auto-Submit: Heschi Kreinick <heschi@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This repository holds the source for various packages and tools that support Go's build system and the development of the Go programming language.
Warning: Packages here are internal to Go's build system and its needs. Some may one day be promoted to another golang.org/x repository, or they may be modified arbitrarily or even disappear altogether. In short, code in this repository is not subject to the Go 1 compatibility promise nor the Release Policy.
This repository uses Gerrit for code changes. To contribute, see https://golang.org/doc/contribute.html.
The main issue tracker for the blog is located at https://github.com/golang/go/issues. Prefix your issue with “x/build/DIR: ” in the subject line.
The main components of the Go build system are:
The coordinator, in cmd/coordinator/, serves https://farmer.golang.org/ and https://build.golang.org/. It runs on GKE and coordinates the whole build system. It finds work to do (both pre-submit “TryBot” work, and post-submit work) and executes builds, allocating machines to run the builds. It is the owner of all machines. It holds the state for which builds passed or failed, and the build logs.
The Go package in buildenv/ contains constants for where the dashboard and coordinator run, for prod, staging, and local development.
The buildlet, in cmd/buildlet/, is the HTTP server that runs on each worker machine to execute builds on the coordinator's behalf. This runs on every possible GOOS/GOARCH value. The buildlet binaries are stored on Google Cloud Storage and fetched per-build, so we can update the buildlet binary independently of the underlying machine images. The buildlet is the most insecure server possible: it has HTTP handlers to read & write arbitrary content to disk, and to execute any file on disk. It also has an SSH tunnel handler. The buildlet must never be exposed to the Internet. The coordinator provisions buildlets in one of three ways:
by creating VMs on Google Compute Engine (GCE) with custom images configured to fetch & run the buildlet on boot, listening on port 80 in a private network.
by running Linux containers (on either Google Kubernetes Engine or GCE with the Container-Optimized OS image), with the container images configured to fetch & run the buildlet on start, also listening on port 80 in a private network.
by taking buildlets out of a pool of connected, dedicated machines. The buildlet can run in either listen mode (as on GCE and GKE) or in reverse mode. In reverse mode, the buildlet connects out to https://farmer.golang.org/ and registers itself with the coordinator. The TCP connection is then logically reversed (using revdial and when the coordinator needs to do a build, it makes HTTP requests to the coordinator over the already-open TCP connection.
These three pools can be viewed at the coordinator's https://farmer.golang.org/#pools.
The env/ directory describes build environments. It contains scripts to create VM images, Dockerfiles to create Kubernetes containers, and instructions and tools for dedicated machines.
maintner in maintner/ is a library for slurping all of Go's GitHub and Gerrit state into memory. The daemon maintnerd in maintner/maintnerd/ runs on GKE and serves https://maintner.golang.org/. The daemon watches GitHub and Gerrit and appends to a mutation log whenever it sees new activity. The logs are stored on GCS and served to clients.
The godata package in maintner/godata/ provides a trivial API to let anybody write programs against Go's maintner corpus (all of our GitHub and Gerrit history), live up to the second. It takes a few seconds to load into memory and a few hundred MB of RAM after it downloads the mutation log from the network.
pubsubhelper in cmd/pubsubhelper/ is a dependency of maintnerd. It runs on GKE, is available at https://pubsubhelper.golang.org/, and runs an HTTP server to receive Webhook updates from GitHub on new activity and an SMTP server to receive new activity emails from Gerrit. It then is a pubsub system for maintnerd to subscribe to.
The gitmirror server in cmd/gitmirror/ mirrors Gerrit to GitHub, and also serves a mirror of the Gerrit code to the coordinator for builds, so we don't overwhelm Gerrit and blow our quota.
The Go gopherbot bot logic runs on GKE. The code is in cmd/gopherbot. It depends on maintner via the godata package.
The developer dashboard at https://dev.golang.org/ runs on GKE. Its code is in devapp/. It also depends on maintner via the godata package.
cmd/retrybuilds: a Go client program to delete build results from the dashboard
The perfdata server, in perfdata/appengine serves https://perfdata.golang.org/. It runs on App Engine and serves the benchmark result storage system.
The perf server, in perf/appengine serves https://perf.golang.org/. It runs on App Engine and serves the benchmark result analysis system. See its README for how to start a local testing instance.
If you wish to run a Go builder, please email golang-dev@googlegroups.com first. There is documentation at https://golang.org/wiki/DashboardBuilders, but depending on the type of builder, we may want to run it ourselves, after you prepare an environment description (resulting in a VM image) of it. See the env directory.