dashboard: don't snapshot XP builders (not shared anyway), and skip pprof tests
Updates golang/go#10267
Updates golang/go#22594
Change-Id: Ib6a9e13fbaaf4aad0b74008146b55e651658d4dd
Reviewed-on: https://go-review.googlesource.com/83115
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
diff --git a/dashboard/builders.go b/dashboard/builders.go
index dd84ea1..7dfd6d0 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -1186,9 +1186,18 @@
env: []string{"GOARCH=amd64", "GOHOSTARCH=amd64"},
})
addBuilder(BuildConfig{
- Name: "windows-386-xp",
- HostType: "host-windows-386-xp",
- MaxAtOnce: 1, // only one anyway
+ Name: "windows-386-xp",
+ HostType: "host-windows-386-xp",
+ MaxAtOnce: 1, // only one anyway
+ SkipSnapshot: true,
+ ShouldRunDistTest: func(distTest string, isTry bool) bool {
+ if strings.Contains(distTest, "vendor/github.com/google/pprof") {
+ // Not worth it. And broken.
+ // See golang.org/issue/22594.
+ return false
+ }
+ return true
+ },
})
addBuilder(BuildConfig{
Name: "darwin-amd64-10_8",
