tree b1091916a3854b86043bd7803cb26b1f85cf59bc
parent fc985e83c96c8a67f06f41b60a3fd7e9776d6173
author Alan Donovan <adonovan@google.com> 1683821919 -0400
committer Alan Donovan <adonovan@google.com> 1683910466 +0000

cmd/buildlet: set GOPLSCACHE=$workdir/goplscache

Ordinarily, gopls processes live such long and idle lives that the
internal garbage collector for gopls' file-based cache can easily keep
up with the churn rate and maintain the shared cache at a reasonable
size. But tests burn twice as bright and half as long and, despite
various efforts, have tended to fill the cache volume; see the
attached Go issues.

This change causes the buildlet to set GOPLSCACHE to a fresh
subdirectory of the work dir for each builder run so that each is
cleaned up at the end of the run. This does mean that the tests don't
exercise the shared cache behavior, but the problems our tests
hitherto uncovered were not particularly representative of production.

Updates golang/go#57900
Updates golang/go#57902

Change-Id: I63e91dd873897eb3619929530bc3a75a16b96095
Reviewed-on: https://go-review.googlesource.com/c/build/+/494297
Run-TryBot: Alan Donovan <adonovan@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>