tree 586d7a43ff72c8b7ca39e114b05b796636893fee
parent 0536f7398f0ea675b219ec14618ca812602e1427
author Dmitri Shuralyov <dmitshur@golang.org> 1621027163 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1621295551 +0000

maintner: discard lock_reason in GitHub issue events

"lock_reason" is a field that was added to GitHub API v3 after maintner
was created. It's present in GitHub issue "locked" events and indicates
the reason the issue was locked, such as "off-topic", "too heated",
"resolved", etc.

Since maintner didn't have explicit handling for it, it got the default
treatment of being saved in OtherJSON just in case.

It's a non-goal for maintner to track all available data, only what is
deemed to be worth including. This field hasn't been used all this time
and seems fine to exclude until something changes.

Also fix a bug where OtherJSON wasn't even set in GitHubIssueEvent,
and improve various internal comments and log messages.

For golang/go#46180.

Change-Id: I9ebb3bf4183f78e413dfb032c94cb736a8b07e02
Reviewed-on: https://go-review.googlesource.com/c/build/+/320289
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>