tree 4274debfcfda201077d291ee1f434dd95e6c5a42
parent 43f0c4da19c15c188d5bc1ec1b85bb9e2a598172
author Dmitri Shuralyov <dmitshur@golang.org> 1568054323 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1568243322 +0000

cmd/coordinator: split subrepo testing into module and GOPATH modes

There are sufficient differences between the work we need to do
to test a subrepo in module mode and GOPATH mode, that it makes
sense to split it into two linear code paths. (I've tried keeping
it inline, but it led to less readable and harder to change code.)

This change is mostly a refactor with the intentional of not changing
any user-visible behavior. Behavior changes will follow in future CLs;
for now they're added as TODO comments.

The GOPATH mode path remains as before; minor improvements will be
applied in the following commit.

The module mode path is reduced to be empty at this time. The main
subrepo being tested is already fetched earlier, and its dependencies
don't need to be placed into a GOPATH workspace in module mode.

Change-Id: Ibfbe30b5d54ebe26cb5a783f0592f754fecfe53d
Reviewed-on: https://go-review.googlesource.com/c/build/+/194357
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>