tree c3d017f45dad695a54256d3a6087fda47a7176b3
parent 914a9f1ff8beced386496e13de94d03329eafb36
author Dmitri Shuralyov <dmitshur@golang.org> 1585685763 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1585714660 +0000

cmd/coordinator: report errors on all gitmirror instances

There are 2 gitmirror instances running since 2017 (CL 36801).
The gitmirror health check has been relying on fetching the HTML
status page from the gitmirror service via its load balancer.

If one of of the two gitmirror instances has a problem, the health
check can miss it and report all okay. This caused the health check
to appear flaky and untrustworthy, even though the underlying failure
in gitmirror is reported reliably.

Start querying all gitmirror instances and report combined errors.
Also report a problem if there are no gitmirror instances running.

Remove the /debug/watcher/ debug endpoint. Its current implementation
is unhelpful because the load balancer causes it to display the status
of a single instance. Making it useful would require significant rework.
In the meantime, the status pages of individual gitmirror instances can
be accessed by using the kubectl port-forward command.

Fixes golang/go#37828.

Change-Id: I3f3e322a85e07f23f18a56a7fd913abed75ee77e
Reviewed-on: https://go-review.googlesource.com/c/build/+/226678
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>