dashboard, cmd/coordinator: support multiple builder owners
Prefer displaying GitHub usernames for convenience of pinging in GitHub
issues, since all current builder owners have them. Keep it possible to
use an email or something else if no GitHub account exists.
Update the owner of the Corellium builders to be individual GitHub
account, so that it can be pinged in an issue. The GitHub organization
is already mentioned in the builder notes.
Also switch to html/template (instead of text/template) for rendering
the builders page.
Fixes golang/go#49596.
Change-Id: I89a96eb8f7a3057bc1f3aaee16abc9c776c45ee7
Reviewed-on: https://go-review.googlesource.com/c/build/+/363983
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
diff --git a/dashboard/builders_test.go b/dashboard/builders_test.go
index cca5e85..d935e3c 100644
--- a/dashboard/builders_test.go
+++ b/dashboard/builders_test.go
@@ -675,6 +675,17 @@
}
}
+// Test that all specified builder owners are non-nil.
+func TestBuilderOwners(t *testing.T) {
+ for host, config := range Hosts {
+ for i, p := range config.Owners {
+ if p == nil {
+ t.Errorf("dashboard.Hosts[%q].Owners[%d] is nil, want non-nil", host, i)
+ }
+ }
+ }
+}
+
// tests that goBranch is optional for repo == "go"
func TestBuildsRepoAtAllImplicitGoBranch(t *testing.T) {
builder := Builders["android-amd64-emu"]
