tree 0fb810734da12b38d012fba0b3d680519e93bfcb
parent 5d9c992396cd2ac86cb158eb2b1c5d39459d22ff
author Rebecca Stambler <rstambler@golang.org> 1591251612 -0400
committer Rebecca Stambler <rstambler@golang.org> 1594140547 +0000

cmd/gopherbot: don't set reviewers if they are the same as current

This change avoids calling SetReview with reviews that would have no
effect on the change. This is particularly relevant for changes imported
from PRs, as they require 2 reviewers. If there is only one owner for
the package, we should avoid continually setting the same reviewer.

This change is implemented by keeping track of all of the human
reviewers on a given change and comparing them to the proposed
reviewers. This is a little complicated, given that the current
reviewers can only be kept track of by their Gerrit IDs, whereas owners
are added by the emails associated with their Gerrit accounts.

Change-Id: I684c8c86fd5c0c2c411450ae48a332ba796f5d60
Reviewed-on: https://go-review.googlesource.com/c/build/+/236438
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>