tree 3d0d6a022c5bcfb44f31c880ff282a68d2c59f85
parent 1d8c3548c0bbc477bdf7cb400b72a4cf9c7d362e
author Dmitri Shuralyov <dmitshur@golang.org> 1537214416 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1537283753 +0000

maintner: skip incomplete CLs in ForeachOpenCL

CL 107296 has created a GerritCL.complete method and started
using it to enforce non-nil Meta and Commit fields in GerritCL
that are returned to the client.

It was used in ForeachCLUnsorted to skip incomplete CLs when
iterating over the gp.cls map, but due to an oversight, it
was not added to ForeachOpenCL. As a result, it was possible
for incomplete CLs to be iterated over via ForeachOpenCL.
This change fixes that by adding the missing complete check.

Update TestGerritMetaNonNil test to check ForeachOpenCL too.

Add missing period at the end of a sentence in ForeachCLUnsorted
documentation.

Fixes golang/go#27536.

Change-Id: I453d0f2b2b2793ed1b8a55bae1c2254906d74792
Reviewed-on: https://go-review.googlesource.com/135677
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>