tree 5eddc1fef07245367a7a0f608cef0ec510d91ff8
parent 65d9afce5ef72406f2cfce19f02143c4a07fe649
author Michael Anthony Knyszek <mknyszek@google.com> 1721328981 +0000
committer Michael Knyszek <mknyszek@google.com> 1721660086 +0000

sweet: collect and dump only hijacked fd 2 for cockroachdb

Currently the performance testing builders are failing because the
CockroachDB servers produce far too much log data for
perfdata.golang.org to handle, and it gets shipped off along with the
benchmark data (it just ends up in the result file). This change stops
logging everything CockroachDB does to stderr and instead redirects to a
dedicated directory. This directory should remain if anything goes
wrong, so we can still use it for debugging, but in normal usage it'll
get blown away. The one thing we want from this directory, however, is
the output originally sent to fd 2 before it was hijacked by
CockroachDB. This output includes things like runtime printlns from
GODEBUG=gctrace=1, among other things, which is important to preserve
for our debugging.

Fixes golang/go#68517.

Change-Id: I319d37e174675a1e7de7d9fcb4ca06076c6c8daf
Cq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/599455
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Austin Clements <austin@google.com>