arm/armasm: drop '$' from constant shift counts in GoSyntax

GoSyntax printed shifted register operands with a constant count as
R0<<$28. The Go assembler rejects the '$' there and expects R0<<28,
which is also what it prints itself.

With this change, 682 of the 1084 plan9 test cases in decode.txt
assemble back to the same encoding with cmd/asm, up from 496.

Updates golang/go#23159

Change-Id: Id6b91aeb8521c0fe272cc30b0f69559432085c6b
Reviewed-on: https://go-review.googlesource.com/c/arch/+/850509
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: David Chase <drchase@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2 files changed
tree: 89e3bc7b4b32f04ce58a9b7fcae9274e9e5cb415
  1. arm/
  2. arm64/
  3. loong64/
  4. ppc64/
  5. riscv64/
  6. s390x/
  7. x86/
  8. .gitattributes
  9. codereview.cfg
  10. CONTRIBUTING.md
  11. go.mod
  12. go.sum
  13. LICENSE
  14. PATENTS
  15. README.md
README.md

arch

Go Reference

This repository holds machine architecture information used by the Go toolchain. The parts needed in the main Go repository are copied in.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://go.dev/doc/contribute.

The git repository is https://go.googlesource.com/arch.

The main issue tracker for the arch repository is located at https://go.dev/issues. Prefix your issue with “x/arch:” in the subject line, so it is easy to find.