x86/xeddata: rewrite Reader to use new readLines iterator

The parsing in readLines is simpler and more robust. It also includes
line information (which would have been pretty annoying to add to the
old parser), so this is a step toward adding position information to
Inst.

One downside of this is that Reader.Read has to use a pull iterator.
However, as far as I can tell, the only callers of this were
Reader.ReadAll and WalkInsts, both of which we rewrite to use
readObjects directly.

Change-Id: I4ca58c877fbfd5295209aea31999c8abd6876f17
Reviewed-on: https://go-review.googlesource.com/c/arch/+/656238
Auto-Submit: Austin Clements <austin@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
3 files changed
tree: b665c1c0762b6a5c73e70dd9cf6f2e3f7b5f4b5d
  1. arm/
  2. arm64/
  3. loong64/
  4. ppc64/
  5. riscv64/
  6. s390x/
  7. x86/
  8. codereview.cfg
  9. CONTRIBUTING.md
  10. go.mod
  11. go.sum
  12. LICENSE
  13. PATENTS
  14. README.md
README.md

arch

Go Reference

This repository holds machine architecture information used by the Go toolchain. The parts needed in the main Go repository are copied in.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://go.dev/doc/contribute.

The git repository is https://go.googlesource.com/arch.

The main issue tracker for the arch repository is located at https://go.dev/issues. Prefix your issue with “x/arch:” in the subject line, so it is easy to find.