project.config: show trybot and unresolved comment submit requirements
The following submit requirements are generally applicable and relevant
in all CLs that go through the Go code review process:
• Code-Review
• TryBots-Pass (and the temporary LUCI-Pass vote used during migration)
• No-Unresolved-Comments
• Review-Enforcement
That is, these submit requirements start out being unmet¹, and all four
of them need to eventually be satisfied before a CL can be submitted.
It seems detrimental to the dev UX to hide them after they're met.
The other submit requirements, such as No-Holds, No-Wait-Release,
Do-Not-Review, Matching-Subject-Prefix, and others are more situational:
they apply in rare cases, and it's fine for them not to show up whenever
they're satisfied.
Refactor our uses of applicableIf and submittableIf to make the above
happen. Also arrange all the visible-when-satisfied submit requirements
to be on top, and all the hidden-unless-unsatisfied submit requirements
to be on at the bottom.
¹ No-Unresolved-Comments technically starts out being met, but I think
it's an important and visible part of the Go code review process to be
promoted to be always visible. We can always change it later if wished.
Change-Id: I1216494c8d985e1af21488339fb7d33c616d4c75
Reviewed-on: https://go-review.googlesource.com/c/All-Projects/+/537736
Reviewed-by: Michael Knyszek <mknyszek@google.com>
1 file changed
