commit 1b22574ddb1f9559c014d7aa13416bd6f4aba26b
author Dmitri Shuralyov <shurcooL@gmail.com> Wed Apr 26 00:16:31 2017 -0400
committer Brad Fitzpatrick <bradfitz@golang.org> Wed Apr 26 05:21:38 2017 +0000
tree 61cab3c6d5f0ad929cfd8f82e5fb5dd6fe47d2cb
parent 4bb9a6d30bdc727aebd0747694f31de632a5282e

cmd/godoc: fix expected test output for Go 1.8 and older

A go/build change in Go 1.9 (CL 33158) allowed for a better expected
error message for "nonexistingpkg" case. CL 37768 did that. However,
that shouldn't be done for Go 1.8 and older, since they don't have
the corresponding go/build change.

So, if the version is Go 1.8 or older, allow matching those previous
expected outputs (before CL 37768) for "nonexistingpkg" case.

Move test cases for TestCLI from a package-level variable into TestCLI
itself. This is more readable, and isGo19's value is ready in time.

Fixes golang/go#20122.

Change-Id: I5e80600a75176d9e54ffebb7730849e381568316
Reviewed-on: https://go-review.googlesource.com/41810
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>