Google Git
Sign in
go / tools / 03f7b7be3ee23c810d775c9e9cf2b3d7cb1830ac
commit03f7b7be3ee23c810d775c9e9cf2b3d7cb1830ac[log] [tgz]
authorIhar Suvorau <ihar.suvorau@gmail.com>Sun Dec 17 00:40:53 2023 +0200
committerGopher Robot <gobot@golang.org>Fri Mar 15 16:51:31 2024 +0000
treed9885d6e6fb5e09f34c1ff154af9e148117d8cdd
parent67e856beabf185fd771e1ef618781c1e84e4f386 [diff]
x/tools/go/packages: fix Load's "argument list too long" error

The current implementation doesn't assume any limit on the amount of
patterns passed to Load which breaks it when called on large codebases.
Different platforms have implemented different values for ARG_MAX,
https://www.in-ulm.de/~mascheck/various/argmax/#results,
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html,
https://devblogs.microsoft.com/oldnewthing/20031210-00/?p=41553.

In this fix, we use a conservative estimation of ARG_MAX (32767)
that would suit all the supported platforms, subtracted by an approx.
length of env on a typical machine (16384). We use this value to split
the provided patterns into chunks to run the underlying driver on chunks
instead of the whole patterns slice.

Fixes golang/go#36909

Change-Id: I7c462c1e905b1f95013afa2b0ce2aa0a435125dc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/550477
Reviewed-by: Michael Matloob <matloob@golang.org>
Auto-Submit: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2 files changed
tree: d9885d6e6fb5e09f34c1ff154af9e148117d8cdd
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.