tree 616ae4a87bab6561a65e51aa35cc40f34866d561
parent b64f02211f1aded539d7a0de5a9e793e68972bf4
author Brad Fitzpatrick <bradfitz@golang.org> 1487817822 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> 1487890102 +0000

http2/hpack: remove hpack's constant time string comparison

Delete the constant time string comparison. It's slow and shows up in
profiles, nobody else does it, and the spec text no longer recommends
doing it. See bug for discussion and details.

Also clean up some naked returns while I'm here (noted during review).

Fixes golang/go#19238

Change-Id: I344c5766c5d97bbcf01eab0624097941591ce00f
Reviewed-on: https://go-review.googlesource.com/37394
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tom Bergan <tombergan@google.com>