tree 35cbef3a6ac1868f8259fec2bab86f7c5e08adeb
parent 0631ecafac46db83db609486bedff561525c03e9
author Brad Fitzpatrick <bradfitz@golang.org> 1455297630 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> 1455319493 +0000

Fix flakiness of TestCancelNoIO with http.Handler-based server transport.

It wasn't closing the recvBuffer body in all cases during shutdown.

This change also:

* adds a new test with concurrent streams doing their own serial sends.
  This test was part of earlier debugging, but exists now to add more
  test coverage around concurrency.

* starts a cleanup of the end2end testing code, to be continued later.
  but the cleanup was necessary when writing the new test to be clean
  and not add more positional parameters.

* documents the concurrency expectations of the ServerTransport
  interface, cleaning up some other nearby documentation in the
  process.

* speeds up TestCancelNoIO to cancel some contexts once no longer
  needed, adding some comments about what the test is doing, adds some
  TODOs, and reduces some overly-long sleeps.