tree 511b760398e9442cbc4d602ec35e064aacce8d9e
parent 4b285768f2a2d5bc15e6d7d32ed6cab83f5b3530
author Dmitri Shuralyov <dmitshur@golang.org> 1715304243 -0400
committer Gopher Robot <gobot@golang.org> 1715374377 +0000

internal/relui: drop v6l suffix from non-linux/arm download metadata

For historical reasons, the binary release for the linux/arm port we
provide at https://go.dev/dl/ is a bit of a special case. It differs
from other ports in that it's built with GOARM overridden to a value
of 6, and the filename has a "v6l" suffix after "arm". The download
metadata has a field "arch" where that v6l suffix is being included.

This special case needs to be handled consistently in various places,
which can be easy to get slightly wrong sometimes (e.g., CL 504820,
go.dev/issue/62514, etc.).

It turns out a GOOS == linux check was missed when porting the metadata
publishing logic from releasebot to relui, causing metadata for Go 1.21
onwards to be "armv6l" for arm ports of all OSes, not just Linux. Cease
doing that in Go 1.23 (the nearest major release, to minimize potential
disruption in minor releases).

Spotted this via https://hachyderm.io/@golang/112044405859439427 which
happened to select the netbsd/arm port. The fact that this hasn't been
reported sooner suggests this isn't a very serious problem fortunately.

Change-Id: I732ca7a6db181e81d31b265df48e7a9f47ed2c6c
Reviewed-on: https://go-review.googlesource.com/c/build/+/584403
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>